test(chrome-extension): add unit test for answer session description init formatting - #2165
Open
gcoinstash-cmd wants to merge 5 commits into
Open
Conversation
Manage your Superagent protectionSuperagent has paused scans for this repository because this unlinked GitHub App installation has used all three included PR scans. You have 0 of 3 included PR scans remaining. Create a free account to continue protection, manage scan settings, review security history, and control which repositories are protected. |
| }); | ||
| }); | ||
|
|
||
| it("throws error when session description is null or undefined", async () => { |
Contributor
There was a problem hiding this comment.
Test overstates invalid-input coverage
The test description names both null and undefined, but its only assertion passes null. This reports coverage for an undefined-input case that the test never executes, making future coverage assessments misleading.
Suggested change
| it("throws error when session description is null or undefined", async () => { | |
| it("throws error when session description is null", async () => { |
Prompt To Fix With AI
This is a comment left during a code review.
Path: apps/chrome-extension/src/shared/webrtc.test.ts
Line: 81
Comment:
**Test overstates invalid-input coverage**
The test description names both `null` and `undefined`, but its only assertion passes `null`. This reports coverage for an undefined-input case that the test never executes, making future coverage assessments misleading.
```suggestion
it("throws error when session description is null", async () => {
```
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
answertype RTCSessionDescription formatting intoSessionDescriptionInit.RTCSessionDescriptionInitobjects for camera-preview peers.Test Validation
pnpm biome check apps/chrome-extension: 0 lint errors across 74 files.pnpm --filter=@cap/chrome-extension test: 21/21 tests passed 100% green in 849ms.Greptile Summary
This PR adds unit coverage for WebRTC session-description formatting and several shared recorder utility behaviors.
RTCSessionDescriptionInit.Confidence Score: 4/5
The PR appears safe to merge, with only a non-blocking mismatch between one test name and the input it exercises.
The added assertions align with the current implementations and supported test runtime; the sole concern is misleadingly stated undefined-input coverage.
Files Needing Attention: apps/chrome-extension/src/shared/webrtc.test.ts
Important Files Changed
Prompt To Fix All With AI
Reviews (1): Last reviewed commit: "test(chrome-extension): add unit test fo..." | Re-trigger Greptile