Skip to content

Describe callora-admin limits scope and consumers #1248

Closed

Description

@greatest0fallt1me

Summary

The callora-admin crate ships per-account caps for bets, positions and subscriptions, concepts absent from the API-marketplace contracts, and no contract depends on it.

Why this matters

Readers cannot tell whether these limits protect real Callora flows or are copied scaffolding, making audit scoping harder.

Scope

Document which contracts are meant to consume callora-admin, what 'bet' and 'position' mean in Callora terms, or mark the module experimental.

Relevant code in CalloraOrg/Callora-Contracts:

  • contracts/admin/src/limits.rs
  • contracts/admin/docs/storage.md
  • contracts/admin/docs/PR_IMPLEMENTATION_SUMMARY.md

Priority

Low

Acceptance criteria

  • Crate-level docs state purpose and consumers
  • storage.md lists all keys used by limits.rs
  • Unused concepts either justified or flagged
  • Doc explains relation to contracts/yield limits which duplicate the concept

Validation

cargo doc -p callora-admin --no-deps

Non-goals

  • Typo-only, formatting-only, or cosmetic changes.
  • Unrelated refactors, dependency upgrades, or broad rewrites.
  • Removing safeguards or weakening validation to make tests pass.

Contributor application

Before coding, describe the affected modules, proposed state/invariant changes, test strategy, compatibility considerations, and an estimate. Wait for assignment before starting implementation.

PR requirements

Use a feature branch and include Closes #<issue-number>. Address every criterion, map criteria to code and tests, explain security and failure-mode handling, and ensure CI passes.

Quality review

A maintainer will assess correctness, completeness, test depth, compatibility, observability, and adverse-case handling. A substantive implementation is required; merge or CI status alone does not guarantee reward eligibility.


Generated by Claude Code

Activity

  1. changed the title [-]Keep leaderboard rank pages deterministic[/-] [+]Add focused test coverage for contracts/topics/src/events.rs[/+] on Sep 27, 2026
  2. changed the title [-]Add focused test coverage for contracts/topics/src/events.rs[/-] [+]Describe callora-admin limits scope and consumers[/+] on Sep 27, 2026
  3. olaams-tech commented on Sep 27, 2026

    @olaams-tech
    Contributor

    @olaams-tech has applied to work on this issue as part of the Stellar Wave Program's 9th wave.

    Hi, I would like to work on this issue. Please assign it to me if it is still available. I’m ready to start immediately and will submit the completed work within 24 hours. Thank you!

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @olaams-tech to this issue.

  4. drips-wave commented on Sep 29, 2026

    @drips-wave

    Congratulations, @olaams-tech! 🎉 Your application was accepted by the repo's maintainers, and the issue is due on September 30, 2026.

    🧑‍💻 @olaams-tech: Please resolve the issue such that the repo's maintainers have enough time to review your contribution before the due date. You'll earn Points for completing the issue on-time, which will make you eligible for a share of the Stellar Wave Program's reward pool.

    Warning

    When opening a PR, please link it to this issue to ensure it gets tracked accurately. Points are awarded when this issue is marked as completed by the maintainer.

    🤠 Repo maintainers: Please keep an eye on the contributor's progress and review their work before the due date. You can manage this issue, including adjusting its complexity and points, here.

    🌊 Happy Wave 🌊

  5. grantfox-oss commented on Sep 29, 2026

    @grantfox-oss

    🎉 This issue has been marked as completed on GrantFox!

    @olaams-tech's PR #1295 was approved and merged by @greatest0fallt1me.

    🏆 @olaams-tech: You earned 35 FoxPoints for this contribution! Your current tier: Explorer (331 total points). Track your full progress on GrantFox.

    👏 Great work, @olaams-tech! Keep contributing to CalloraOrg.

  6. drips-wave commented on Sep 29, 2026

    @drips-wave

    This issue has been completed by @olaams-tech as part of the Stellar Wave Program's 9th Wave 🥳

    😎 @olaams-tech: You earned 100 Points for completing this issue! After the current Wave ends, you'll be eligible for a percentage of the Wave's reward pool based on the percentage of total points you've earned. Learn more here. You can also Leave a review to share your experience working on this issue.

    🧑‍💻 Repo maintainers: How'd the contributor do? Leave a review to share your experience working with them.

  7. 13 remaining items

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Stellar WaveStellar Wave Program issue

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions