Repository navigation
feat(runtime): add reviewed PowerShell/Bash and Debug terminal - #97
Merged
Merged
Conversation
This was referenced Aug 18, 2026
Qiyuanqiii
marked this pull request as ready for review
August 18, 2026 14:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
debug_terminal.v1only to the root Supervisor in Code/Local/Deliver/Debug with the current runtime adapter and durable permission; every write is rechecked by Shell Policy and commands requiring separate approval are denieddebug_terminalto the durable Supervisor call ledger with a transactional, data-preserving v112 migration; update README, usage, architecture, OpenAPI text, macOS test guidance, and ADR 0114PR #86 review/corrections
This branch is rebased on
mainafter #86 merged as13de12d. It preserves that PR's Windows/WebView2/DPI evidence and corrects integration points affected by the larger runtime surface:Security and compatibility boundaries
transport=processrejects PowerShell/Bash, so only the explicit canonical Shell branch can select themterminal_sessionsremains a contract only and is not used to restore authorityVerification
go test -timeout 20m -count=1 ./...go vet ./...go test -race ./internal/application -run "TestDebugTerminal" -count=1 -timeout 10mgo test -race ./internal/terminal -count=1 -timeout 10mgo test -tags "desktop,wv2runtime.error" -count=1 ./cmd/cyberagent-desktop ./internal/desktop ./internal/webui -timeout 10m./internal/terminalnpm test -- --run— 59 files / 243 tests passednpm run typecheck,npm run check:api,npm run buildnpm audit --audit-level=high— 0 vulnerabilitiesgo mod verifyandgo mod tidy -diffGOTOOLCHAIN=go1.26.6 go run golang.org/x/vuln/cmd/govulncheck@v1.6.0 ./...— 0 reachable vulnerabilities (one required-module vulnerability is not called)-NoLogo -NoProfile -NonInteractive -Command; Git for Windows 2.54.0.windows.1 / Bash 5.3.9 with--noprofile --norc -c.\scripts\build-desktop.ps1 -SkipFrontend -VerifyReproducible— reproducible, SHA-2566269d2a28c717e95afbc55490bef36139b5eb82cc83d41c0d302b77ba82b56ffManual evidence still required
The PR is intentionally Draft. macOS currently has compile coverage but still needs a real Bash/PTY run and UI evidence on macOS. The Windows reproducible build reports
windows_release_ready=falseonly because signing/install/manual release evidence is outside this change; automated Windows checks passed.