Repository navigation
fix(git): fail closed on pending operation replay - #95
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
Both services persisted an intent before the side effect, but every matching operation-key replay returned success immediately. If execution, the remote API, or receipt persistence failed, the durable row remained incomplete and all later retries falsely looked successful with an empty receipt.
Recovery semantics
The service does not automatically rerun an incomplete intent because the original Git/API side effect may already have happened. It returns
FAILED_PRECONDITION; the operator must reconcile observable state and then use a new operation key if a fresh action is appropriate. Completed records keep their existing idempotent replay behavior.Verification
go test -count=1 -v ./internal/application -run "TestGitMutationService|TestGitRemoteService"go test -count=1 ./internal/store ./internal/repositorygo vet ./internal/applicationgit diff --check