Skip to content

fix(supervisor): complete proposal tool registry - #93

Merged
Qiyuanqiii merged 5 commits into
mainfrom
codex/fix-docker-supervisor-tool
Aug 18, 2026
Merged

Qiyuanqiii merged 5 commits into
mainfrom
codex/fix-docker-supervisor-tool

Conversation

@Qiyuanqiii

@Qiyuanqiii Qiyuanqiii commented Aug 18, 2026 •

Copy link
Copy Markdown
Member

Summary

  • make every advertised Supervisor proposal tool valid across definition lookup, payload normalization, Gateway validation, domain validation, application allowlists, and production executor wiring
  • add forward-only schema v109 so durable Supervisor calls accept child_task_propose, sandbox_docker_run_propose, and one_shot_command_propose while preserving existing rows and triggers
  • connect the one-shot command proposal to its existing human review/execution chain
  • fix ListOnceCommandProposals deadlocking on SQLite's single connection by closing the ID cursor before loading full records
  • add registry parity and real Supervisor-to-ledger regression coverage

Root cause

Supervisor tools were registered in several independent allowlists. PRs #67, #62, and #78 added child-task, Docker, and one-shot proposal pieces without keeping every layer synchronized. Child and Docker calls were visible to the model but could not be persisted; one-shot calls were not reachable at all. Its operator list path also performed a nested query while holding SQLite's only connection.

Safety

  • the migration is additive and preserves all existing call rows
  • one-shot remains proposal-only; it does not execute until the existing human review and permission gates approve it
  • command payloads remain redacted from the generic tool transcript

Verification

  • go mod verify
  • go test -count=1 ./...
  • go vet ./...
  • registry/README migration parity checks
  • real Supervisor → one-shot proposal persistence → model result round trip

@Qiyuanqiii Qiyuanqiii changed the title fix(supervisor): admit Docker proposal tool fix(supervisor): complete proposal tool registry Aug 18, 2026
feat(skills): 模式感知安装账本与人工审查候选
@Qiyuanqiii
Qiyuanqiii marked this pull request as ready for review August 18, 2026 07:24
@Qiyuanqiii
Qiyuanqiii merged commit 0063c70 into main Aug 18, 2026
8 checks passed
@NanaseInori
NanaseInori deleted the codex/fix-docker-supervisor-tool branch September 16, 2026 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant