Repository navigation
fix: reject unknown Run execution statuses - #9
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
run_statusagainst the closed Run status enum in execution responsesWhy
The generated OpenAPI contract exposes
run_statusas a closed enum, but the runtime parser accepted any string. A malformed or drifted server response could therefore enter UI state instead of failing as an invalid response.Impact
The client now fails closed when execution response status semantics drift from the Go/OpenAPI contract. Valid statuses are unchanged.
Checks
npm test -- --run src/api/client.test.ts(66 tests)npm test(55 files, 212 tests)npm run typechecknpm run check:apinpm run buildnpm audit --audit-level=moderategit diff --checkAll checks ran with Node 24.19.0. Vite retains the existing large-chunk warning.