Repository navigation
test: normalize macOS temporary paths - #8
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Why
On macOS,
testing.T.TempDir()may return/var/...while the filesystem resolves it through the system/varto/private/varalias. Tests that intentionally reject indirect paths then reject their own trusted fixture roots. This caused the full local Go suite to fail consistently across browser runtime, sandbox, and Workspace path tests despite the production boundary behaving as designed.Impact
The security tests now supply canonical direct fixture paths on macOS without weakening any production validation. Linux and Windows retain the same effective test paths.
Checks
go mod verifygo test -timeout 20m -count=1 ./...go vet ./...git diff --checkAll Go checks used Go 1.25.12.