Repository navigation
test: isolate Session composer locale state - #30
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SessionSteeringQueuetests independent from the earlierSessionComposersuiteWhy
The queue suite renders through
LocaleProviderand asserts English labels, but its locale was only initialized by a siblingdescribeblock. The full file passed in declaration order while focused queue runs, shuffled execution, or future suite refactors could default to Chinese and fail for reasons unrelated to queue behavior.Validation
npm ci(0 vulnerabilities)npm test(57 files, 218 tests)npm run typecheckgit diff --checkThe existing jsdom canvas warnings remain informational and unchanged.