Repository navigation
fix(code-intel): classify closed process pipes as crashes - #189
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
os.ErrClosedfrom an owned LSP stdout pipe ascrashedRoot cause
After PR #188 merged, main CI run 33101468059 intermittently failed
TestManagerBoundsCrashTimeoutCancellationProtocolAndOversizeFailures/crash. The owned helper process exited, butCmd.Waitand the stdout read loop raced to publish the terminal transport error. When the read loop won withread LSP message: read |0: file already closed,healthForErrordid not recognize the wrappedos.ErrClosedand recordedunavailableinstead ofcrashed.The same SHA passed the PR Go suite and the Real LSP Ubuntu race suite, confirming that this is an existing scheduling-dependent classification gap rather than a typography regression. PR #161 fixed a different done-before-pending publication race; this patch preserves that ordering and only canonicalizes the equivalent closed-pipe crash signal.
Validation
go test -timeout 5m -count=1 ./internal/codeintelgo vet ./internal/codeintelgit diff --checkAn independent review found no P0-P2 issues. The integration test continues to require
crashed; this change does not weaken the expected behavior.