fix(label_list): emit reorder only after completed drops#1389
Closed
xy200303 wants to merge 1 commit into
Closed
Conversation
Owner
|
Thanks for the contribution. After testing this, we decided not to move forward with the PR. The current drag-reordering behavior can introduce data-loss risks: dragging items in the Shapes list may cause some objects to disappear from both the list and the canvas. Also, this reordering feature has limited practical value for the current annotation workflow, so keeping it would add interaction risk without enough benefit. We’ll close this PR and disable shape-list dragging for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
pytest -q tests/test_label_list_widget.pyNotes
在右侧列表拖动多个对象时会导致闪退)onnxruntimeaccess violation during package initialization on Windows