Skip to content

fix(label_list): emit reorder only after completed drops#1389

Closed
xy200303 wants to merge 1 commit into
CVHub520:mainfrom
xy200303:fix/object-list-drag-drop-crash
Closed

fix(label_list): emit reorder only after completed drops#1389
xy200303 wants to merge 1 commit into
CVHub520:mainfrom
xy200303:fix/object-list-drag-drop-crash

Conversation

@xy200303

@xy200303 xy200303 commented Jun 12, 2026

Copy link
Copy Markdown
  • I have read and agree to the CLA.

Summary

  • fix the object list reorder signal so it only fires after a completed internal drop
  • disable overwrite-mode drops in the object list to avoid replacing items when dropping onto another object
  • add regression tests for non-drop removals and drag/drop configuration

Verification

  • pytest -q tests/test_label_list_widget.py

Notes

@CVHub520

Copy link
Copy Markdown
Owner

Thanks for the contribution. After testing this, we decided not to move forward with the PR.

The current drag-reordering behavior can introduce data-loss risks: dragging items in the Shapes list may cause some objects to disappear from both the list and the canvas. Also, this reordering feature has limited practical value for the current annotation workflow, so keeping it would add interaction risk without enough benefit.

We’ll close this PR and disable shape-list dragging for now.

#1385

@CVHub520 CVHub520 closed this Jun 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants