[PLT-1390] Removing DPC sns topic key references.#355
Merged
Conversation
juliareynolds-nava
approved these changes
Dec 12, 2025
gfreeman-navapbc
approved these changes
Dec 12, 2025
juliareynolds-nava
pushed a commit
that referenced
this pull request
Jan 6, 2026
## 🎫 Ticket https://jira.cms.gov/browse/PLT-1390 ## 🛠 Changes This PR removes TF data references to the now deleted DPC SNS topic key, which was removed from the dpc-ops repo in a related PR. ## ℹ️ Context As part of the alarm-to-slack service work the DPC CloudWatch alarm topic was updated to use the shared dpc-\<env\> KMS key instead of the custom DPC SNS topic key, and that custom key was destroyed. This PR cleans up references to that custom key that continued to exist in the github-actions-role service. ## 🧪 Validation <details> <summary>Tofu plan output (DPC-DEV)</summary> ``` OpenTofu will perform the following actions: # aws_iam_role_policy.github_actions_role_policy will be updated in-place ~ resource "aws_iam_role_policy" "github_actions_role_policy" { id = "dpc-dev-github-actions:terraform-2025xxxxxxxxxxxxxxxxxxxxxx" name = "terraform-2025xxxxxxxxxxxxxxxxxxxxxx" ~ policy = jsonencode( ~ { ~ Statement = [ # (12 unchanged elements hidden) { Action = [ "kms:ListAliases", "kms:GetKeyRotationStatus", "kms:GetKeyPolicy", "kms:EnableKeyRotation", "kms:CreateKey", "kms:CreateAlias", ] Effect = "Allow" Resource = "*" Sid = "KmsUsage" }, ~ { ~ Resource = [ # (3 unchanged elements hidden) "arn:aws:kms:us-east-1:xxxxxxxxxxxx:alias/dpc-dev-web-admin-cloudwatch-key", - "arn:aws:kms:us-east-1:xxxxxxxxxxxx:alias/dpc-dev-sns-topic-key", "arn:aws:kms:us-east-1:xxxxxxxxxxxx:alias/dpc-dev-master-key", # (4 unchanged elements hidden) ] # (3 unchanged attributes hidden) }, { Action = [ "firehose:StartDeliveryStreamEncryption", "firehose:DescribeDeliveryStream", "firehose:CreateDeliveryStream", ] Effect = "Allow" Resource = "*" }, # (12 unchanged elements hidden) ] # (1 unchanged attribute hidden) } ) # (2 unchanged attributes hidden) } Plan: 0 to add, 1 to change, 0 to destroy. ``` </details>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
https://jira.cms.gov/browse/PLT-1390
🛠 Changes
This PR removes TF data references to the now deleted DPC SNS topic key, which was removed from the dpc-ops repo in a related PR.
ℹ️ Context
As part of the alarm-to-slack service work the DPC CloudWatch alarm topic was updated to use the shared dpc-<env> KMS key instead of the custom DPC SNS topic key, and that custom key was destroyed. This PR cleans up references to that custom key that continued to exist in the github-actions-role service.
🧪 Validation
Tofu plan output (DPC-DEV)