-
Notifications
You must be signed in to change notification settings - Fork 7
AB2D-7301 Enable Datadog sidecar on ECS services #1801
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
gfreeman-navapbc
wants to merge
9
commits into
main
Choose a base branch
from
gfreeman/AB2D-7301
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
650af45
add service module updates for all services
gfreeman-navapbc c96eaf5
update tofu plan and apply to account for more than one container wit…
gfreeman-navapbc 51cf8d8
fix command to just ignore agent containers
gfreeman-navapbc 8625614
remove zsh-specific syntax
gfreeman-navapbc a766c8a
update api module to have alb handled by cdap service module
gfreeman-navapbc d23568f
remove unused data call
gfreeman-navapbc 4a6addc
Merge branch 'main' into gfreeman/AB2D-7301
gfreeman-navapbc ff1025b
add permission for events queue
gfreeman-navapbc 0b2b776
Merge branch 'main' into gfreeman/AB2D-7301
gfreeman-navapbc File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| 1.10.1 | ||
| 1.12.1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| # ------------------------------------------------------- | ||
| # Additional Task Policies — | ||
| # ------------------------------------------------------- | ||
| resource "aws_iam_policy" "contracts" { | ||
| name = "${module.platform.app}-${module.platform.env}-contracts" | ||
| description = "Additional IAM permissions for the AB2D Contracts module beyond the base service and platform modules" | ||
| policy = data.aws_iam_policy_document.contracts.json | ||
| } | ||
|
|
||
| data "aws_iam_policy_document" "contracts" { | ||
| statement { | ||
| sid = "CloudWatchMetricsAccess" | ||
| effect = "Allow" | ||
| actions = [ | ||
| "cloudwatch:PutMetricData" | ||
| ] | ||
| resources = ["*"] | ||
| condition { | ||
| test = "StringEquals" | ||
| variable = "cloudwatch:namespace" | ||
| values = ["ab2d/${module.platform.env}/contracts"] | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| # ------------------------------------------------------- | ||
| # Additional Task Policies — | ||
| # ------------------------------------------------------- | ||
| resource "aws_iam_policy" "events" { | ||
| name = "${module.platform.app}-${module.platform.env}-events" | ||
| description = "Additional IAM permissions for the AB2D Events module beyond the base service and platform modules" | ||
| policy = data.aws_iam_policy_document.events.json | ||
| } | ||
|
|
||
| data "aws_iam_policy_document" "events" { | ||
| statement { | ||
| sid = "SQSAccess" | ||
| effect = "Allow" | ||
| actions = [ | ||
| "sqs:SendMessage", | ||
| "sqs:ReceiveMessage", | ||
| "sqs:DeleteMessage", | ||
| "sqs:GetQueueUrl", | ||
| "sqs:GetQueueAttributes" | ||
| ] | ||
| resources = [ | ||
| "arn:aws:sqs:${module.platform.primary_region.name}:${module.platform.aws_caller_identity.account_id}:ab2d-${module.platform.env}-events" | ||
| ] | ||
| } | ||
|
|
||
| statement { | ||
| sid = "CloudWatchMetricsAccess" | ||
| effect = "Allow" | ||
| actions = [ | ||
| "cloudwatch:PutMetricData" | ||
| ] | ||
| resources = ["*"] | ||
| condition { | ||
| test = "StringEquals" | ||
| variable = "cloudwatch:namespace" | ||
| values = ["ab2d/${module.platform.env}/events"] | ||
| } | ||
| } | ||
| } | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noting this is required as broad, right? There's not a specific resource to define here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct, we have to narrow things down by the namespace, as far as google/chat leads me to believe