Repository navigation
Conversation
HipBinUtil::exec decoded the pclose status with WEXITSTATUS alone. When /bin/sh execs the single compile command (bash does, and macOS /bin/sh is bash), the compiler is popen's direct child; if it dies from a signal, such as a clang assertion's SIGABRT, the status is WIFSIGNALED and WEXITSTATUS yields 0, so hipcc exited 0 without writing the object. Map a signal death to 128 + signal number, the shell convention, which is also what dash reports when it does not exec. Fixes CHIP-SPV/chipStar#1948
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HipBinUtil::exec decoded the pclose status with WEXITSTATUS only, so when the shell execs the compiler and it dies from a signal (for example a clang assertion), hipcc exited 0 with no object. Signal deaths now map to 128 + signal number.
For CHIP-SPV/chipStar#1948
This PR was generated using AI