Open
Conversation
The sed command with the regex fails to keep the sha1 and remove the commit title from the 'Fixes' trailer. Then the git command fails to find the commit. A commit with 'Fixes' can not be validated by the script. Fix the regex to extract the sha1. Signed-off-by: Jeremie Leska <jeremie.leska@6wind.com>
This log was introduced for debug. Remove it. Fixes: 0a4b09f ("cffi: allows to usage of libyang v4") Signed-off-by: Jeremie Leska <jeremie.leska@6wind.com>
It is not always possible to get the features from the parsed module. It is the case for a module obtained from a sysrepo printed context. Introduce compiled_enabled_features that returns the features from the compiled object. Signed-off-by: Jeremie Leska <jeremie.leska@6wind.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This log was introduced for debug. Remove it.
Fixes: 0a4b09f ("cffi: allows to usage of libyang v4")