Skip to content

Fix fragmentation cache#322

Merged
SiskaPavel merged 5 commits intomasterfrom
fix-fragmentation-cache
Mar 2, 2026
Merged

Fix fragmentation cache#322
SiskaPavel merged 5 commits intomasterfrom
fix-fragmentation-cache

Conversation

@TheSableCZ
Copy link
Contributor

@TheSableCZ TheSableCZ commented Feb 17, 2026 •
edited
Loading

Summary

Several fixes related to fragmentation cache and parser issues.

Details

  • Fragmentation stats were incorrectly computed because recursion in put_pkt method.
  • The subsequent fragments (not the first ones) were filled with random ports because the parser continued parsing the L4 layer.
  • Packet data were not reset correctly in parser.

✅ Checks

  • Relevant documentation was updated (if needed)
  • CI pipeline passes (build, tests, lint, static analysis)
  • New code follows clang-tidy rules
  • The change is clearly related to a specific issue / requirement
  • Documentation (e.g. Doxygen) is updated if needed
  • The PR is rebased on the latest master
  • No unrelated changes are included

TheSableCZ and others added 5 commits February 11, 2026 17:24
@TheSableCZ
cache: extract put_pkt method into put_pkt_recursive
fbadce4 
This change allows extracting side-effect parts which must be called once.
@TheSableCZ
cache: ensure that try_to_fill_ports_to_fragmented_packet is called o…
44be25f 
…nly once
@TheSableCZ
parser: do not parse L4 if packet is continuing fragment
bf6c354
@TheSableCZ
parser: reset all packet data with calling constructor
a964b28 
Fixes some members not resetting.
Fixes inconsistent creation of fragmentation key and subsequent
incorrect indexing in fragmentation table which was caused by not
resetting ip addresses.
Fixes incorrect marking some packets as fragments which was caused by
not resetting frag_id and frag_off.
@TheSableCZ
cache: track timeouted fragments in FragmentationCache telemetry
dffd2dc
@SiskaPavel SiskaPavel merged commit 22618e4 into master Mar 2, 2026
8 checks passed
@SiskaPavel SiskaPavel deleted the fix-fragmentation-cache branch March 2, 2026 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SiskaPavel SiskaPavel Awaiting requested review from SiskaPavel

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@TheSableCZ @SiskaPavel