feat(database-client): add db.sql tagged template - #191
Conversation
|
@codex review |
🦋 Changeset detectedLatest commit: 2f6b1ba The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Greptile SummaryThe PR adds a parameterized
Confidence Score: 5/5The PR appears safe to merge with no actionable correctness, security, or compatibility issues identified. The tagged template preserves interpolation order, routes values through the established encoder, constructs a normal Statement with positional arguments, and is covered across construction and execution paths.
|
| Filename | Overview |
|---|---|
| packages/database-client/src/client.ts | Adds the public Database.sql tagged-template method using positional placeholders and existing value encoding. |
| packages/database-client/src/client.test.ts | Covers placeholder generation, templates without interpolations, object rejection, and statement execution. |
| packages/database-client/README.md | Documents parameterization, return behavior, supported binding semantics, and identifier limitations. |
| .changeset/database-client-sql-template.md | Records the database-client API addition as a patch release. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart LR
T[Tagged SQL template] --> J[Join literal segments with ?]
V[Interpolated values] --> E[encodeValue]
J --> S[Statement]
E --> A[Positional arguments]
A --> S
S --> X[Existing statement execution API]
Reviews (1): Last reviewed commit: "update changeset" | Re-trigger Greptile
|
Codex Review: Didn't find any major issues. 🚀 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
No description provided.