[Feature] Create analyzer#3981
Conversation
AboubakrNasef
requested review from
DevJonny,
holytshirt,
iancooper and
preardon
as code owners
![codescene-delta-analysis[bot]](https://avatars.githubusercontent.com/in/53921?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
This looks valuable, thank you. Can you do me a favour and put together a short ADR to describe it. That also helps for generating documentation. But otherwise happy to merge |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
sure i will do |
iancooper
added
2 - In Progress
dependencies
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
@AboubakrNasef Thanks for the ADR. I will give it a full review tomorrow. I think that Roslyn Analyzers to help with configuration are a great idea. |
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
|
@AboubakrNasef Thanks for the ADR. Can you fix the following for Claude's review (above): Issues to Address
Thanks. Keen to get started on Analyzer help, so looking forward to this tidying so that we can get it in |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
thanks for the review |
|
@AboubakrNasef Do me a favor and merge master, then I will get it out asap |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
here we go i've merged with master |
|
@AboubakrNasef There seems to be a build issue around names. Presumably a merge issue. Can you take a look? |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Gates Passed
See analysis details in CodeScene
Quality Gate Profile: Clean Code Collective
Install CodeScene MCP: safeguard and uplift AI-generated code. Catch issues early with our IDE extension and CLI tool.
|
i've fixed the issues if you can take a look @iancooper |
|
@AboubakrNasef Cool. I will need to get it into the build, but let me raise a separate issue so that I can handle that. The failing tests here a separate issue, and not from this work. Thanks, once this is in, we can more easily add new skills. |
* init brighter analyzer * add message pump analyzer * finalize subscription analyzer * add analyzer for the wrapper Attributes * wip Rules documentation * enhance csproj * clean some files * resolve comments * add adr * resolve comments * refactor the function of report attributes * fix pr comments wip * remove resources.resx and packageid * add WrapAttributeAnalyzer to the adr * add missing tests project * remove package id
3 participants
the current implemented analyzers will be reporting :
Warning about missing RequestType on publication
Warning about RequestType on publication doesn't implement IRequest
Warning about missing messagePump
Warning when you tries to wrapper attribute in MapToRequest
Warning when you tries to unwrapper attribute in MapToMessage
#3681