Feature/add support for TickerQ

[AboubakrNasef]

[Feature] Add Support for TickerQ #3691

[CLAassistant]

All committers have signed the CLA.

[iancooper]

Thanks @AboubakrNasef. I'll ping @ lillo42 as his review is important to me.

[iancooper]

Looks like a build error from a typo:

Error: /home/runner/work/Brighter/Brighter/tests/Paramore.Brighter.Hangfire.Tests/When_scheduling_a_message.cs(73,40): error CS0103: The name 'Compatibilityevel' does not exist in the current context [/home/runner/work/Brighter/Brighter/tests/Paramore.Brighter.Hangfire.Tests/Paramore.Brighter.Hangfire.Tests.csproj::TargetFramework=net9.0]

[iancooper]

@lillo42 If you give me the thumbs up, I can approve

[iancooper]

Looking good @AboubakrNasef. Just a couple of niggles to fix up.

[iancooper]

@AboubakrNasef If you can fix up the files (licences etc.) we can merge this

[AboubakrNasef]

@AboubakrNasef If you can fix up the files (licences etc.) we can merge this

im not sure how to do so
I've fixed the cla license agreement
but then i don't know what to do
if you can guide me I'll be thankful 😅

[iancooper]

if you can guide me I'll be thankful 😅

No worries, you have given us a contribution, so we are the ones who should be thankful.

So, you need to add a licence header to your source files (don't worry about the tests). You can see what you need to add here: https://docs.google.com/document/d/1H_AlNNiQK5645NLYCtGfEJs21FAe8Zj5bGxOks0F2Ew/edit?tab=t.0#heading=h.lewf11cspa2r. It goes at the top of the file, and you need to add your name in the copyright. (Under the CLA you kept your copyright but granted us a perpetual licence)

If you look in the comments, there is a #region in TickerQScheduler.cs. Take that out

If you look in the comments, there is a suggestion to wrap ScheduleAsync rather than wrapping the one call within Schedule. You have done this elsewhere; use an expression-bodied function and call BrighterAsyncContext.Run(async () => await ScheduleAsync ...

[iancooper]

Still not clear? Just shout.

[codescene-delta-analysis]

Gates Passed
4 Quality Gates Passed

See analysis details in CodeScene

Quality Gate Profile: Clean Code Collective
Want more control? Customize Code Health rules or catch issues early with our IDE extension and CLI tool.

[AboubakrNasef]

i've added the licensce now

[AboubakrNasef]

If you look in the comments, there is a suggestion to wrap ScheduleAsync rather than wrapping the one call within Schedule. You have done this elsewhere; use an expression-bodied function and call BrighterAsyncContext.Run(async () => await ScheduleAsync ...

for this suggestion i cant agree with because of the creation of the FireSchedulerMessage and FireSchedulerRequest
should add if its async or not
wrapping the call of the schedule to BrighterAsyncContext.Run(async () => await ScheduleAsync
will make the schedule sync act as async and for that it will fail the tests
so thats why these two specific is like that and the others is just wrapping the async calls

[iancooper]

Thanks @AboubakrNasef I am going to merge now. We are very grateful for your contribution. I hope to release a new version this weekend which should include this.

We always appreciate contributions, please keep the coming.

[lillo42]

Hey @AboubakrNasef can you create a PR with version 9 of Ticker?

[AboubakrNasef]

@lillo42
you mean fork brighter v9 and add tickerQ?

[lillo42]

No, I mean, you have implemented the TicketQ using the version 2.5.3, but the latest version compatible with Brighter is TicketQ 9.0.0, we use that version

[AboubakrNasef]

ok ive checked they just updated the versions
i'll update it
thank you

[iancooper]

@AboubakrNasef No worries, I need to get a build out, and due to a vulnerability, I am fixing it. I'll let you know when it is done, and you can review my changes

[AboubakrNasef]

@iancooper
sorry for being late on this
i had an accident just got out of hospital today with broken leg

i did start on this already they have some breaking changes they did
i can review the changes if you made it and confirm with you 😅

[iancooper]

i had an accident just got out of hospital today with broken leg
Ouch. Hope you mend soon

i did start on this already they have some breaking changes they did
No worries. I'll do a good enough job to move on, then tag you in an issue to check

[iancooper]

@AboubakrNasef BTW, I am moving to their version 8, as they seem to have dropped support for all but 10 in their latest release.