Callback Registration should check async then sync interfaces#3822
Merged
Conversation
…back, prior version would not check for async first.
iancooper
requested review from
DevJonny,
holytshirt and
preardon
as code owners
iancooper
added
3 - Done
Bug
.NET
![codescene-delta-analysis[bot]](https://avatars.githubusercontent.com/in/53921?s=60&v=4){kind=small}
There was a problem hiding this comment.
Gates Passed
See analysis details in CodeScene
Quality Gate Profile: Clean Code Collective
Want more control? Customize Code Health rules or catch issues early with our IDE extension and CLI tool.
DevJonny
pushed a commit
to DevJonny/Brighter
that referenced
this pull request
Feb 28, 2026
…erCommand#3822) * check in specs * first stab at specs * chore: share instructions between Claude and Copilot * fix: typos in markdown files * Clarify transport definition in documentation * Fix wording and formatting in transports.md * feat: producer specification * feat: add more information on channel factories * fea: add callbacks * feat: update producers * fix: ensure that we check both sync and async interfaces for the callback, prior version would not check for async first.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code was using the marker interface
IAmAProducerand not the derived interfacesIAmAProducerSyncandIAmAProducerAsyncwhich means that it was not correctly confirming the type of producer before registering the callback. In addition, we should prefer the async to the sync callback