Skip to content

feat: Update ServiceLifetime #3689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lillo42 merged 4 commits into from
Aug 1, 2025
Merged

feat: Update ServiceLifetime #3689

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8df0c4e
feat: Update ServiceLifetime
lillo42 Jul 31, 2025
c889c5d
feat: uncomment code
lillo42 Jul 31, 2025
f875900
Merge branch 'master' into fix-service-lifetime
lillo42 Jul 31, 2025
ecaae9d
fix: Unit Tests
lillo42 Aug 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions src/Paramore.Brighter.Extensions.DependencyInjection/BrighterOptions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,9 @@ public class BrighterOptions : IBrighterOptions
public InstrumentationOptions InstrumentationOptions { get; set; }

/// <summary>
/// Configures the lifetime of mappers. Defaults to Singleton
/// Configures the lifetime of mappers. Defaults to transit
/// </summary>
public ServiceLifetime MapperLifetime { get; set; } = ServiceLifetime.Singleton;
public ServiceLifetime MapperLifetime { get; set; } = ServiceLifetime.Transient;

/// <summary>
/// Configures the polly policy registry.
Expand All @@ -51,9 +51,7 @@ public class BrighterOptions : IBrighterOptions
/// <summary>
/// Configures the lifetime of any transformers. Defaults to Singleton
/// </summary>
public ServiceLifetime TransformerLifetime { get; set; } = ServiceLifetime.Singleton;


public ServiceLifetime TransformerLifetime { get; set; } = ServiceLifetime.Transient;
}

public interface IBrighterOptions
Expand Down
2 changes: 1 addition & 1 deletion src/Paramore.Brighter.Extensions.DependencyInjection/ServiceCollectionExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ public static IBrighterBuilder BrighterHandlerBuilder(IServiceCollection service
public static IBrighterBuilder AddProducers(
this IBrighterBuilder brighterBuilder,
Action<ProducersConfiguration> configure,
ServiceLifetime serviceLifetime = ServiceLifetime.Scoped)
ServiceLifetime serviceLifetime = ServiceLifetime.Transient)
{
if (brighterBuilder is null)
throw new ArgumentNullException($"{nameof(brighterBuilder)} cannot be null.", nameof(brighterBuilder));
Expand Down
2 changes: 1 addition & 1 deletion tests/Paramore.Brighter.Extensions.Tests/AssemblyResolutionDefaultTransientTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ public void ShouldHaveTestHandlerRegisteredCorrectly()
[Fact]
public void ShouldHaveTestMapperRegisteredCorrectly()
{
TestRegistration(typeof(TestEventMessageMapper), ServiceLifetime.Singleton);
TestRegistration(typeof(TestEventMessageMapper), ServiceLifetime.Transient);
}

[Fact]
Expand Down
2 changes: 1 addition & 1 deletion ...xtensions.Tests/AssemblyResolutionHandlerLifetimeScopedAndMapperLifetimeSingletonTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ public void ShouldHaveTestHandlerRegisteredCorrectly()
[Fact]
public void ShouldHaveTestMapperRegisteredCorrectly()
{
TestRegistration(typeof(TestEventMessageMapper), ServiceLifetime.Singleton);
TestRegistration(typeof(TestEventMessageMapper), ServiceLifetime.Transient);
}

[Fact]
Expand Down
Loading