Skip to content

Fix Nullable#3676

Merged
iancooper merged 13 commits into
masterfrom
nullable_di
Jul 20, 2025
Merged

Fix Nullable#3676
iancooper merged 13 commits into
masterfrom
nullable_di

Conversation

@iancooper

Copy link
Copy Markdown
Member

Rolls out nullable to remaining projects

@iancooper iancooper added 2 - In Progress Breaking Change v10 .NET Pull requests that update .net code labels Jul 19, 2025
@iancooper iancooper marked this pull request as ready for review July 19, 2025 23:38

@codescene-delta-analysis codescene-delta-analysis Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Health Improved (1 files improve in Code Health)

Gates Passed
4 Quality Gates Passed

See analysis details in CodeScene

View Improvements
File Code Health Impact Categories Improved
DynamoDbTableFactory.cs 7.11 → 7.55 Code Duplication
MsSqlInbox.cs no change Code Duplication
SqliteInbox.cs no change Code Duplication

Quality Gate Profile: Clean Code Collective
Want more control? Customize Code Health rules or catch issues early with our IDE extension and CLI tool.

@codescene-delta-analysis codescene-delta-analysis Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Health Improved (1 files improve in Code Health)

Gates Passed
4 Quality Gates Passed

See analysis details in CodeScene

View Improvements
File Code Health Impact Categories Improved
DynamoDbTableFactory.cs 7.11 → 7.55 Code Duplication
MsSqlInbox.cs no change Code Duplication
SqliteInbox.cs no change Code Duplication

Quality Gate Profile: Clean Code Collective
Want more control? Customize Code Health rules or catch issues early with our IDE extension and CLI tool.

@codescene-delta-analysis codescene-delta-analysis Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Health Improved (1 files improve in Code Health)

Gates Passed
4 Quality Gates Passed

See analysis details in CodeScene

View Improvements
File Code Health Impact Categories Improved
DynamoDbTableFactory.cs 7.11 → 7.55 Code Duplication
MsSqlInbox.cs no change Code Duplication
SqliteInbox.cs no change Code Duplication

Quality Gate Profile: Clean Code Collective
Want more control? Customize Code Health rules or catch issues early with our IDE extension and CLI tool.

@codescene-delta-analysis codescene-delta-analysis Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Health Improved (1 files improve in Code Health)

Gates Passed
4 Quality Gates Passed

See analysis details in CodeScene

View Improvements
File Code Health Impact Categories Improved
DynamoDbTableFactory.cs 7.11 → 7.55 Code Duplication
MsSqlInbox.cs no change Code Duplication
SqliteInbox.cs no change Code Duplication

Quality Gate Profile: Clean Code Collective
Want more control? Customize Code Health rules or catch issues early with our IDE extension and CLI tool.

@codescene-delta-analysis codescene-delta-analysis Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Health Improved (1 files improve in Code Health)

Gates Passed
4 Quality Gates Passed

See analysis details in CodeScene

View Improvements
File Code Health Impact Categories Improved
DynamoDbTableFactory.cs 7.11 → 7.55 Code Duplication
MsSqlInbox.cs no change Code Duplication
SqliteInbox.cs no change Code Duplication

Quality Gate Profile: Clean Code Collective
Want more control? Customize Code Health rules or catch issues early with our IDE extension and CLI tool.

@codescene-delta-analysis codescene-delta-analysis Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Health Improved (1 files improve in Code Health)

Gates Passed
4 Quality Gates Passed

See analysis details in CodeScene

View Improvements
File Code Health Impact Categories Improved
DynamoDbTableFactory.cs 7.11 → 7.55 Code Duplication
MsSqlInbox.cs no change Code Duplication
SqliteInbox.cs no change Code Duplication

Quality Gate Profile: Clean Code Collective
Want more control? Customize Code Health rules or catch issues early with our IDE extension and CLI tool.

@iancooper iancooper merged commit 902ecd5 into master Jul 20, 2025
23 of 24 checks passed
@iancooper iancooper deleted the nullable_di branch July 20, 2025 12:07
DevJonny pushed a commit to DevJonny/Brighter that referenced this pull request Feb 28, 2026
* chore: ensuring we are nullable

* chore: ensure that we use nullable

* chore: fix nullable issues

* chore: enforce nullable

* fix: enable nullable

* fix: ensure nullability

* fix: enable nullable

* fix: enable nullability

* fix: enable nullable

* fix: missing enable nullable

* fix: incompatible content types can cause test issues

* fix: unreliable date test issues

* fix: seek to make RMQ tests more reliable on character decoding
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3 - Done Breaking Change .NET Pull requests that update .net code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant