[Feature] Add support to Apache RocketMQ by lillo42 · Pull Request #3650 · BrighterCommand/Brighter

lillo42 · 2025-07-04T11:12:59Z

Add support to Apache RocketMQ

# Conflicts: # Brighter.sln # Directory.Packages.props

codescene-delta-analysis

Gates Failed
Enforce advisory code health rules (2 files with Complex Method, Constructor Over-Injection)

Gates Passed
3 Quality Gates Passed

See analysis details in CodeScene

Reason for failure

Enforce advisory code health rules	Violations	Code Health Impact
RocketMqMessageProducer.cs	1 advisory rule	10.00 → 9.45	Suppress
RocketMqSubscription.cs	1 advisory rule	10.00 → 9.69	Suppress

Quality Gate Profile: Clean Code Collective
Want more control? Customize Code Health rules or catch issues early with our IDE extension and CLI tool.

codescene-delta-analysis · 2025-07-04T11:13:55Z

+    public RocketMqSubscription(SubscriptionName? subscriptionName = null, ChannelName? channelName = null,
+        RoutingKey? routingKey = null, string? consumerGroup = null, int bufferSize = 1, int noOfPerformers = 1,
+        TimeSpan? timeOut = null, int requeueCount = -1, TimeSpan? requeueDelay = null,
+        int unacceptableMessageLimit = 0, MessagePumpType messagePumpType = MessagePumpType.Unknown,
+        IAmAChannelFactory? channelFactory = null, OnMissingChannel makeChannels = OnMissingChannel.Create,
+        FilterExpression? filter = null, TimeSpan? emptyChannelDelay = null,
+        TimeSpan? channelFailureDelay = null, TimeSpan? receiveMessageTimeout = null,
+        TimeSpan? invisibilityTimeout = null) : base(typeof(T), subscriptionName, channelName, routingKey, consumerGroup, bufferSize,
+        noOfPerformers, timeOut, requeueCount, requeueDelay, unacceptableMessageLimit, messagePumpType, channelFactory,
+        makeChannels, filter, emptyChannelDelay, channelFailureDelay, receiveMessageTimeout,
+        invisibilityTimeout)
+    {
+    }


❌ New issue: Constructor Over-Injection
RocketMqSubscription has 18 arguments, threshold = 5

_Suppress

codescene-delta-analysis

Gates Failed
Enforce advisory code health rules (2 files with Complex Method, Constructor Over-Injection)

Gates Passed
3 Quality Gates Passed

See analysis details in CodeScene

Reason for failure

Enforce advisory code health rules	Violations	Code Health Impact
RocketMqMessageProducer.cs	1 advisory rule	10.00 → 9.45	Suppress
RocketMqSubscription.cs	1 advisory rule	10.00 → 9.69	Suppress

Quality Gate Profile: Clean Code Collective
Want more control? Customize Code Health rules or catch issues early with our IDE extension and CLI tool.

codescene-delta-analysis · 2025-07-07T08:50:22Z

+    public RocketSubscription(Type dataType,
+        SubscriptionName? subscriptionName = null,
+        ChannelName? channelName = null,
+        RoutingKey? routingKey = null,
+        string? consumerGroup = null,
+        int bufferSize = 1,
+        int noOfPerformers = 1,
+        TimeSpan? timeOut = null,
+        int requeueCount = -1,
+        TimeSpan? requeueDelay = null,
+        int unacceptableMessageLimit = 0,
+        MessagePumpType messagePumpType = MessagePumpType.Unknown,
+        IAmAChannelFactory? channelFactory = null,
+        OnMissingChannel makeChannels = OnMissingChannel.Create,
+        FilterExpression? filter = null,
+        TimeSpan? emptyChannelDelay = null,
+        TimeSpan? channelFailureDelay = null,
+        TimeSpan? receiveMessageTimeout = null,
+        TimeSpan? invisibilityTimeout = null) : base(dataType, subscriptionName, channelName, routingKey, bufferSize,
+        noOfPerformers, timeOut, requeueCount, requeueDelay, unacceptableMessageLimit, messagePumpType, channelFactory,
+        makeChannels, emptyChannelDelay, channelFailureDelay)
+    {
+        ConsumerGroup = consumerGroup ?? string.Empty;
+        ReceiveMessageTimeout = receiveMessageTimeout ?? TimeSpan.FromMinutes(1);
+        InvisibilityTimeout = invisibilityTimeout ?? TimeSpan.FromSeconds(30);
+        Filter = filter ?? new FilterExpression("*");
+    }


❌ New issue: Constructor Over-Injection
RocketSubscription has 19 arguments, threshold = 5

_Suppress

codescene-delta-analysis

Gates Failed
Enforce advisory code health rules (2 files with Complex Method, Constructor Over-Injection)

Gates Passed
3 Quality Gates Passed

See analysis details in CodeScene

Reason for failure

Enforce advisory code health rules	Violations	Code Health Impact
RocketMqMessageProducer.cs	1 advisory rule	10.00 → 9.47	Suppress
RocketMqSubscription.cs	1 advisory rule	10.00 → 9.69	Suppress

Quality Gate Profile: Clean Code Collective
Want more control? Customize Code Health rules or catch issues early with our IDE extension and CLI tool.

Copilot

Pull Request Overview

Adds support for Apache RocketMQ by introducing new gateway implementations, extensive test coverage, and environment setup.

Introduces RocketMQ-specific connection, subscription, producer, and consumer classes under src/Paramore.Brighter.MessagingGateway.RocketMQ.
Provides synchronous and asynchronous end-to-end tests for RocketMQ integration in tests/Paramore.Brighter.RocketMQ.Tests.
Updates solution, package references, and adds a Docker Compose file for local RocketMQ services.

Reviewed Changes

Copilot reviewed 39 out of 39 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
tests/.../Utils/GatewayFactory.cs	Test utility for creating RocketMQ connections, producers, consumers
tests/.../TestDoubles/*.cs	Test doubles for message mappers, handlers, and commands
src/Paramore.Brighter.MessagingGateway.RocketMQ/RocketMqSubscription.cs	Subscription configuration classes for RocketMQ
src/Paramore.Brighter.MessagingGateway.RocketMQ/RocketMqMessageProducer.cs	RocketMQ message producer implementation
src/Paramore.Brighter.MessagingGateway.RocketMQ/RocketMessageConsumer.cs	RocketMQ message consumer implementation
src/Paramore.Brighter.MessagingGateway.RocketMQ/RocketMqChannelFactory.cs	Factory for creating sync/async channels
src/Paramore.Brighter.MessagingGateway.RocketMQ/RocketMessagingGatewayConnection.cs	RocketMQ connection configuration
docker-compose-rocketmq.yaml	Docker Compose setup for RocketMQ Nameserver, Broker, Proxy, Dashboard
Directory.Packages.props	Added `RocketMQ.Client` package version
Brighter.sln	Included the RocketMQ projects in the solution

Comments suppressed due to low confidence (1)

src/Paramore.Brighter.MessagingGateway.RocketMQ/RocketMqSubscription.cs:10

The class name RocketSubscription does not match the file name RocketMqSubscription.cs; consider renaming the class to RocketMqSubscription for consistency.

public class RocketSubscription : Subscription

Copilot · 2025-07-12T14:45:02Z

+
+        if (!string.IsNullOrEmpty(message.Header.Subject))
+        {
+            builder.AddProperty(HeaderNames.Subject, message.Header.Subject);


The Subject header is added twice; remove the duplicate AddProperty call for Subject to avoid redundant entries.

# Conflicts: # Brighter.sln

codescene-delta-analysis

Gates Failed
Enforce advisory code health rules (2 files with Complex Method, Constructor Over-Injection)

Gates Passed
3 Quality Gates Passed

See analysis details in CodeScene

Reason for failure

Enforce advisory code health rules	Violations	Code Health Impact
RocketMqMessageProducer.cs	1 advisory rule	10.00 → 9.50	Suppress
RocketMqSubscription.cs	1 advisory rule	10.00 → 9.69	Suppress

Quality Gate Profile: Clean Code Collective
Want more control? Customize Code Health rules or catch issues early with our IDE extension and CLI tool.

codescene-delta-analysis · 2025-07-21T07:47:54Z

+    public async Task SendWithDelayAsync(Message message, TimeSpan? delay, CancellationToken cancellationToken = default)
+    {
+        var builder = new Org.Apache.Rocketmq.Message.Builder()
+            .SetBody(message.Body.Bytes)
+            .SetTopic(mqPublication.Topic!.Value);
+
+        builder.AddProperty(HeaderNames.MessageId, message.Id)
+            .AddProperty(HeaderNames.Topic, message.Header.Topic.Value)
+            .AddProperty(HeaderNames.HandledCount, message.Header.HandledCount.ToString())
+            .AddProperty(HeaderNames.MessageType, message.Header.MessageType.ToString())
+            .AddProperty(HeaderNames.TimeStamp, message.Header.TimeStamp.ToRfc3339())
+            .AddProperty(HeaderNames.Source, message.Header.Source.ToString())
+            .AddProperty(HeaderNames.SpecVersion, message.Header.SpecVersion)
+            .AddProperty(HeaderNames.Type, message.Header.Type);
+
+        if (!string.IsNullOrEmpty(message.Header.Subject))
+        {
+            builder.AddProperty(HeaderNames.Subject, message.Header.Subject);
+        }
+
+        if (message.Header.DataSchema != null)
+        {
+            builder.AddProperty(HeaderNames.DataSchema, message.Header.DataSchema.ToString());
+        }
+
+        if (!string.IsNullOrEmpty(message.Header.Type))
+        {
+            builder.AddProperty(HeaderNames.Type, message.Header.Type);
+        }
+
+        builder.AddProperty(HeaderNames.ContentType, message.Header.ContentType.ToString());
+        builder.AddProperty(HeaderNames.DataContentType, message.Header.ContentType.ToString());
+
+        if (!string.IsNullOrEmpty(message.Header.CorrelationId))
+        {
+            builder.AddProperty(HeaderNames.CorrelationId, message.Header.CorrelationId);
+        }
+
+        if (!RoutingKey.IsNullOrEmpty(message.Header.ReplyTo))
+        {
+            builder.AddProperty(HeaderNames.ReplyTo, message.Header.ReplyTo);
+        }
+
+        if (!string.IsNullOrEmpty(message.Header.DataRef))
+        {
+            builder.AddProperty(HeaderNames.DataRef, message.Header.DataRef);
+        }
+
+        if (delay.HasValue && delay.Value != TimeSpan.Zero)
+        {
+            builder
+                .SetDeliveryTimestamp(connection.TimerProvider.GetUtcNow().Add(delay.Value).UtcDateTime);
+        }
+
+        if (!PartitionKey.IsNullOrEmpty(message.Header.PartitionKey))
+        {
+            builder.SetMessageGroup(message.Header.PartitionKey);
+        }
+
+        foreach (var (key, val) in message.Header.Bag
+                     .Where(x => x.Key != HeaderNames.Keys && x.Key != HeaderNames.Tag))
+        {
+            builder.AddProperty(key, val.ToString());
+        }
+
+        if (message.Header.Bag.TryGetValue(HeaderNames.Keys, out var keys))
+        {
+            if (keys is string[] keysArray)
+            {
+                builder.SetKeys(keysArray);
+            }
+            else if (keys is string keyString)
+            {
+                builder.SetKeys(keyString);
+            }
+        }
+        else
+        {
+            builder.SetKeys(message.Id);
+        }
+
+        if (message.Header.Bag.TryGetValue(HeaderNames.Tag, out var tag) && tag is string tagString)
+        {
+            builder.SetTag(tagString);
+        }
+        else if (!string.IsNullOrEmpty(mqPublication.Tag))
+        {
+            builder.SetTag(mqPublication.Tag);
+        }
+
+        await producer.Send(builder.Build());
+        BrighterTracer.WriteProducerEvent(Span, MessagingSystem.RocketMQ, message, instrumentation);
+    }


❌ New issue: Complex Method
SendWithDelayAsync has a cyclomatic complexity of 18, threshold = 9

_Suppress

* Add RocketMQ * Fixes issue to build * Init test * Improve test * Add unit test rocketmq * add unit for rocketmq * fix change ChangeInvisibleDuration * fix: Add fragile tag * fix: improve consumer group * fix: add missing file * feat: update csproj and remove content type null check * feat: Code Review remove duplicated property * set ChannelFactoryType for RocketMQ subscription * Add trace

Rafael Lillo and others added 12 commits February 20, 2025 23:10

Add RocketMQ

a83c97e

Fixes issue to build

21140ee

Merge with master

b72255a

Init test

6faadcf

Merge branch 'master' into add.support.rocket-mq

660ff60

# Conflicts: # Brighter.sln # Directory.Packages.props

Improve test

27b1df9

Merge branch 'master' into add.support.rocket-mq

5cc80b2

# Conflicts: # Brighter.sln # Directory.Packages.props

Add unit test rocketmq

da28532

add unit for rocketmq

9f3c742

fix change ChangeInvisibleDuration

9d10636

fix: Add fragile tag

b6155aa

Merge branch 'master' into add.support.rocket-mq

6ce1b56

codescene-delta-analysis Bot reviewed Jul 4, 2025

View reviewed changes

iancooper added 2 - In Progress feature request .NET Pull requests that update .net code V10.X labels Jul 4, 2025

lillo42 added 3 commits July 7, 2025 09:41

fix: improve consumer group

3b51e9d

fix: add missing file

32eef22

Merge branch 'master' into add.support.rocket-mq

6075c65

codescene-delta-analysis Bot reviewed Jul 7, 2025

View reviewed changes

lillo42 added 2 commits July 10, 2025 09:57

Merge branch 'master' into add.support.rocket-mq

a3aaa95

feat: update csproj and remove content type null check

705e1be

codescene-delta-analysis Bot reviewed Jul 10, 2025

View reviewed changes

lillo42 self-assigned this Jul 10, 2025

lillo42 marked this pull request as ready for review July 10, 2025 09:15

lillo42 requested review from DevJonny, holytshirt, iancooper and preardon as code owners July 10, 2025 09:15

iancooper requested a review from Copilot July 12, 2025 14:43

Copilot AI reviewed Jul 12, 2025

View reviewed changes

BrighterCommand deleted a comment from Copilot AI Jul 12, 2025

lillo42 added 4 commits July 15, 2025 11:19

Merge branch 'master' into add.support.rocket-mq

02bc1bc

feat: Code Review remove duplicated property

ae1dafc

Merge branch 'master' into add.support.rocket-mq

9058489

set ChannelFactoryType for RocketMQ subscription

685be5d

iancooper approved these changes Jul 18, 2025

View reviewed changes

lillo42 added 2 commits July 21, 2025 08:30

Merge branch 'master' into add.support.rocket-mq

ff7ac92

# Conflicts: # Brighter.sln

Add trace

01bd3e6

codescene-delta-analysis Bot reviewed Jul 21, 2025

View reviewed changes

lillo42 merged commit 4374161 into BrighterCommand:master Jul 21, 2025
22 of 23 checks passed

lillo42 deleted the add.support.rocket-mq branch July 21, 2025 07:56

dependabot Bot mentioned this pull request Oct 13, 2025

Bump Paramore.Brighter from 9.9.12 to 10.0.1 VerifyTests/Verify.Brighter#304

Closed

This was referenced May 7, 2026

Bump Paramore.Brighter from 9.9.13 to 10.4.1 mzet97/ZetAuction#14

Closed

Bump Paramore.Brighter.Extensions.DependencyInjection from 9.9.13 to 10.4.1 mzet97/ZetAuction#15

Closed

Bump Paramore.Brighter and Paramore.Brighter.PostgreSql mzet97/ZetAuction#16

Open

dependabot Bot mentioned this pull request Jun 9, 2026

Bump Paramore.Brighter.Extensions.DependencyInjection from 9.9.13 to 10.5.1 mzet97/ZetAuction#24

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Feature] Add support to Apache RocketMQ#3650

[Feature] Add support to Apache RocketMQ#3650
lillo42 merged 23 commits into
BrighterCommand:masterfrom
lillo42:add.support.rocket-mq

lillo42 commented Jul 4, 2025

Uh oh!

codescene-delta-analysis Bot left a comment

Uh oh!

codescene-delta-analysis Bot Jul 4, 2025

Uh oh!

codescene-delta-analysis Bot left a comment

Uh oh!

codescene-delta-analysis Bot Jul 7, 2025

Uh oh!

codescene-delta-analysis Bot left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Jul 12, 2025

Uh oh!

codescene-delta-analysis Bot left a comment

Uh oh!

codescene-delta-analysis Bot Jul 21, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

lillo42 commented Jul 4, 2025

Uh oh!

codescene-delta-analysis Bot left a comment

Choose a reason for hiding this comment

Uh oh!

codescene-delta-analysis Bot Jul 4, 2025

Choose a reason for hiding this comment

Uh oh!

codescene-delta-analysis Bot left a comment

Choose a reason for hiding this comment

Uh oh!

codescene-delta-analysis Bot Jul 7, 2025

Choose a reason for hiding this comment

Uh oh!

codescene-delta-analysis Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Jul 12, 2025

Choose a reason for hiding this comment

Uh oh!

codescene-delta-analysis Bot left a comment

Choose a reason for hiding this comment

Uh oh!

codescene-delta-analysis Bot Jul 21, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants