Skip to content

Add support to CombinedChannelFactory.cs#3556

Merged
iancooper merged 4 commits into
BrighterCommand:masterfrom
lillo42:add-support-combined-channel
Mar 19, 2025
Merged

Add support to CombinedChannelFactory.cs#3556
iancooper merged 4 commits into
BrighterCommand:masterfrom
lillo42:add-support-combined-channel

Conversation

@lillo42

@lillo42 lillo42 commented Mar 7, 2025

Copy link
Copy Markdown
Contributor

I didn't find any way to use multi-transport, so on this PR, I'm adding the CombinedChannelFactory and sample using Kafka and RabbitMQ producing and consuming messages

@codescene-delta-analysis codescene-delta-analysis Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gates Passed
4 Quality Gates Passed

See analysis details in CodeScene

Quality Gate Profile: Clean Code Collective
Want more control? Customize Code Health rules or catch issues early with our IDE extension and CLI tool.

@codescene-delta-analysis codescene-delta-analysis Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gates Passed
4 Quality Gates Passed

See analysis details in CodeScene

Quality Gate Profile: Clean Code Collective
Want more control? Customize Code Health rules or catch issues early with our IDE extension and CLI tool.

@iancooper iancooper added the RC1 label Mar 16, 2025

@codescene-delta-analysis codescene-delta-analysis Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gates Passed
4 Quality Gates Passed

See analysis details in CodeScene

Quality Gate Profile: Clean Code Collective
Want more control? Customize Code Health rules or catch issues early with our IDE extension and CLI tool.

/// <inheritdoc />
public IAmAChannelAsync CreateAsyncChannel(Subscription subscription)
{
foreach (var factory in factories)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I probably have the dumb. But why does the loop return after creating the channel for the first factory?

@iancooper iancooper merged commit 911d6a0 into BrighterCommand:master Mar 19, 2025
@lillo42 lillo42 deleted the add-support-combined-channel branch June 16, 2025 08:19
DevJonny pushed a commit to DevJonny/Brighter that referenced this pull request Feb 28, 2026
* Add support to CombinedChannelFactory.cs

* Resolve the factory by subscription channel factory type

---------

Co-authored-by: Ian Cooper <ian_hammond_cooper@yahoo.co.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants