Fixes DefaultMapper & SNS/SQS Publish#3488
Merged
iancooper merged 3 commits intoJan 20, 2025
Merged
Conversation
lillo42
requested review from
DevJonny,
holytshirt,
iancooper and
preardon
as code owners
![codescene-delta-analysis[bot]](https://avatars.githubusercontent.com/in/53921?s=60&v=4){kind=small}
Comment on lines
+103
to
+108
|
|
||
| if (!string.IsNullOrEmpty(message.Header.CorrelationId)) | ||
| { | ||
| messageAttributes.Add(HeaderNames.CorrelationId, | ||
| new MessageAttributeValue { StringValue = message.Header.CorrelationId, DataType = "String" }); | ||
| } |
There was a problem hiding this comment.
ℹ Getting worse: Complex Method
SendAsync increases in cyclomatic complexity from 9 to 10, threshold = 9
lillo42
commented
Jan 20, 2025
iancooper
approved these changes
Jan 20, 2025
DevJonny
pushed a commit
to DevJonny/Brighter
that referenced
this pull request
Feb 28, 2026
* Fixes sample & JsonMapper * Move to ConcurrentDictionary
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3486: