fix: BrighterTaskScheduler Queue Task When Complete#3450
Merged
Conversation
iancooper
requested review from
DevJonny,
holytshirt and
preardon
as code owners
![codescene-delta-analysis[bot]](https://avatars.githubusercontent.com/in/53921?s=60&v=4){kind=small}
| #endregion | ||
|
|
||
| using System; | ||
| using System.Runtime.CompilerServices; |
There was a problem hiding this comment.
❌ Getting worse: Code Duplication
introduced similar code in: Run_AsyncTaskWithResultAndConfigurateAwait_BlockingCode_Still_Ends
DevJonny
pushed a commit
to DevJonny/Brighter
that referenced
this pull request
Feb 28, 2026
…3450) * fix: add immediate execution back * fix: use a new thread if the context has closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we complete adding, due to us pumping the pending continuations for a task, we struggle if we are then handed another continuation via the scheduler, as the blockingcollection is complete. (This seems to be a function of ConfigureAwait being called with false on an await in our scope - not sure wy)
In this case, we just use a "Hail Mary" approach (cribbed from RavenDb) of putting the queued task on a new thread.