Fixes for Kafka Tests following the Proactor/Reactor split#3447
Merged
Conversation
…nd local culture decisions. Use invariant
…set auto-create for Kafka topics to false.
…ts can only run locally, due to timing issues
![codescene-delta-analysis[bot]](https://avatars.githubusercontent.com/in/53921?s=60&v=4){kind=small}
| /// </remarks> | ||
| /// <param name="cancellationToken"></param> | ||
| public Task PurgeAsync(CancellationToken cancellationToken = default(CancellationToken)) | ||
| public async Task PurgeAsync(CancellationToken cancellationToken = default(CancellationToken)) |
There was a problem hiding this comment.
❌ New issue: Code Duplication
The module contains 4 functions with similar structure: CommitAllOffsets,CommitOffsets,PurgeAsync,ReceiveAsync
…'t run locally if not in debug, but better to note these over never running
iancooper
requested review from
DevJonny,
holytshirt and
preardon
as code owners
Member
Author
|
Likely to be a straight check in from PR as it is fixing broken tests |
DevJonny
pushed a commit
to DevJonny/Brighter
that referenced
this pull request
Feb 28, 2026
…ommand#3447) * fix: broken Kafka test * fix: simplify the management of kafka tests with directories * fix: make time base test more reliable * chore: note issue with test and schema registry * fix: issues with posting a message with delay * fix: fix issues with timing * fix: time and date issues caused by inconsistency between invariant and local culture decisions. Use invariant * fix: note around skip tests that breaks if Docker container does not set auto-create for Kafka topics to false. * fix: kafka producer should flush on close; test uses assume not create * fix: make the kafka tests more robust * fix: when we don't publish on async, must manually raise deliveryreport * fix: close of consumer now more reliable in flushing offsets * fix: try to make more reliable, changes to receive. many proactor tests can only run locally, due to timing issues * chore: skip another test impacted by timing in CI * chore: move tests to fragile that don't execute well in CI - many won't run locally if not in debug, but better to note these over never running * chore: ensure fragile tests marked as such for CI * chore: kill Confluent tests, they are not being run ever * chore: another CI fragile test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.