Skip to content

[Bug] Omit item from DynamoDb Delivered index when undelivered v10 #3390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iancooper merged 1 commit into from
Nov 21, 2024
Merged

[Bug] Omit item from DynamoDb Delivered index when undelivered v10 #3390

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Paramore.Brighter.Outbox.DynamoDB/MessageItem.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ public class MessageItem
/// </summary>
[DynamoDBGlobalSecondaryIndexRangeKey(indexName: "Delivered")]
[DynamoDBProperty]
public long DeliveryTime { get; set; }
public long? DeliveryTime { get; set; }

/// <summary>
/// A JSON object representing a dictionary of additional properties set on the message
Expand Down Expand Up @@ -130,7 +130,7 @@ public MessageItem(Message message, int shard = 0, long? expiresAt = null)
CreatedAt = date.ToString("yyyy-MM-ddTHH:mm:ss.fffZ");
CreatedTime = date.Ticks;
OutstandingCreatedTime = date.Ticks;
DeliveryTime = 0;
DeliveryTime = null;
HeaderBag = JsonSerializer.Serialize(message.Header.Bag, JsonSerialisationOptions.Options);
MessageId = message.Id.ToString();
MessageType = message.Header.MessageType.ToString();
Expand Down