[Docs] Add ADR for generating metrics from traces#3389
Conversation
|
@iancooper fyi a first draft |
![codescene-delta-analysis[bot]](https://avatars.githubusercontent.com/in/53921?s=60&v=4){kind=small}
jtsalva
requested review from
DevJonny,
holytshirt,
iancooper and
preardon
as code owners
holytshirt
left a comment
holytshirt
left a comment
There was a problem hiding this comment.
Nicely written up, thank you!
|
BTW @jtsalva We should follow the Metrics conventions for Open Telemetry, In particular, we will want to make sure that we use the Messaging metric conventions, for Brighter when it is sending a message or receiving a message. It would be nice to also to use the Db Metric conventions, for our *box implementations. For the traces, I built against the in-memory bus and *box options first, so that I can then go through and add these to the real implementations; that might work as an approach here too. It lets you break up the PRs for example. |
|
@iancooper makes sense. I've updated this ADR and raised #3453, both ready for review :) |
Great, I think the ADR is nicely written, so very happy to approve. Will review #3453 |
* [Feature] Generate metrics from traces #3389 * Minor fixes * Add name to new files --------- Co-authored-by: Ian Cooper <ian_hammond_cooper@yahoo.co.uk>
…mand#3389) * Drafting metrics from traces adr * Drafting * Update in line with code changes --------- Co-authored-by: Ian Cooper <ian_hammond_cooper@yahoo.co.uk>
* [Feature] Generate metrics from traces BrighterCommand#3389 * Minor fixes * Add name to new files --------- Co-authored-by: Ian Cooper <ian_hammond_cooper@yahoo.co.uk>
3 participants
This aims to be a good enough starting point. There are more metrics I think Brighter could provide and some ideas on how, things like
ApproximateAgeOfOldestMessage- deferring for later discussion.