Skip to content

[Feature] Parallel Publish#3182

Merged
iancooper merged 10 commits into
masterfrom
parallel_publish
Jul 7, 2024
Merged

[Feature] Parallel Publish#3182
iancooper merged 10 commits into
masterfrom
parallel_publish

Conversation

@iancooper

Copy link
Copy Markdown
Member

Change the approach on a CommandProcessor Publish to use parallelism: a parallel for on a sync publish and a Task.WhenAll on an async publish.

@iancooper iancooper marked this pull request as ready for review July 3, 2024 07:20
@iancooper iancooper self-assigned this Jul 5, 2024
@iancooper iancooper added Breaking Change feature request v10 .NET Pull requests that update .net code labels Jul 5, 2024

@preardon preardon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. As discussed I will need to think about how to Handle DI scopes in the Publish flow as at the minute I believe they share one

@iancooper

Copy link
Copy Markdown
Member Author

Looks good to me. As discussed I will need to think about how to Handle DI scopes in the Publish flow as at the minute I believe they share one

Indeed. Let's address that in another PR, as I think it needs some thought (and an ADR)

@iancooper iancooper merged commit 5fa452c into master Jul 7, 2024
@iancooper iancooper deleted the parallel_publish branch July 7, 2024 14:27
DevJonny pushed a commit to DevJonny/Brighter that referenced this pull request Feb 28, 2026
* feature: use parallel publishing to events as no need to process them in sequence.

* fix: ensure that we catch all exceptions from the run

* fix: clean up using statements

* fix: make RequestContext.cs thread safe

* docs: add an adr for the publish change

* fix: don't make the message property multi-threaded as likely only set from one thread

* docs: make it clear that you can access the span if you set it
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants