Conversation
preardon
requested review from
DevJonny,
holytshirt and
iancooper
as code owners
iancooper
approved these changes
Jun 12, 2024
iancooper
left a comment
iancooper
left a comment
Member
There was a problem hiding this comment.
Makes sense; I don't know ASB well enough to spot any issues. I would guess that you might end up with a base and derived classes to avoid branching eventually, but its a refactoring so we can wait to see if that is needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull request gives the ability to configure Service bus to use a Queue instead of a Topic.
At this point in time you will have to set the configuration in both the
PublicationandSubscriptiontoUseServiceBusQueue=true(Currently defaulted to False)