Archiver Dependencies#3090
Merged
Merged
Conversation
…archiver to take a direct Outbox dependency
Member
Author
|
I looked at breaking up External Service Bus as part of this as it has grown large. I abandoned that because it became more complex. The External Service Bus manages the interaction of producer and outbox, which are already separate classes. When you try breaking this up into Outbox and Producer components, you realize that you are just creating an abstraction over that inter-relationship, which doesn't gain anything as it is already abstracted into producer and outbox. So there still does not seem to be a refactoring route that helps here |
…ndency for the bus
DevJonny
pushed a commit
to DevJonny/Brighter
that referenced
this pull request
Feb 28, 2026
* Move archive functionality to external service bus, prevent need for archiver to take a direct Outbox dependency * Move archiver function to bus; organize CP tests * Test that external bus archive works as expected * Add tests around archiving async messages * Add a test to show we only archive dispatched * Ensure tests for archiving cover the boundary conditions * Fix issues with the setup not taking in the new ArchiverProvider dependency for the bus
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The archiver has dependencies on Outbox interfaces, and understands how to archive from them. This does not match the Sweeper, where the Sweeper's role is timed calling of methods on the Command Processor to Clear messages. We want to move the archive functionality into the service bus (which deals with our Outboxes from clients) and have the archive sweeper call that.
The Command Processor tests folder is getting pretty busy, so we will deal with that with folders; we will add tests of the archive functionality under there.