move to using declarations#3066
Merged
iancooper merged 3 commits intoApr 26, 2024
Merged
Conversation
SimonCropp
requested review from
DevJonny,
holytshirt,
iancooper and
preardon
as code owners
iancooper
reviewed
Apr 24, 2024
iancooper
reviewed
Apr 24, 2024
iancooper
reviewed
Apr 24, 2024
iancooper
reviewed
Apr 24, 2024
iancooper
reviewed
Apr 24, 2024
iancooper
reviewed
Apr 24, 2024
iancooper
reviewed
Apr 24, 2024
iancooper
reviewed
Apr 24, 2024
iancooper
reviewed
Apr 24, 2024
iancooper
reviewed
Apr 24, 2024
iancooper
reviewed
Apr 24, 2024
iancooper
reviewed
Apr 24, 2024
iancooper
reviewed
Apr 24, 2024
iancooper
reviewed
Apr 24, 2024
iancooper
reviewed
Apr 24, 2024
iancooper
reviewed
Apr 24, 2024
iancooper
reviewed
Apr 24, 2024
iancooper
requested changes
Apr 24, 2024
iancooper
left a comment
iancooper
left a comment
Member
There was a problem hiding this comment.
I am concerned about nested using statements when replaced with a declaration, as we need to check that there is no dependency that one needs to be shut before the other. This is particularly a problem with streams. We can end up with data not written to streams. So we may want to review those. The other nested statements around the Db should be fine.
iancooper
approved these changes
Apr 26, 2024
Member
|
Thanks @SimonCropp |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.