Revoke Partitions generating errors, when doing unneeded work#3063
Merged
Conversation
iancooper
requested review from
DevJonny,
holytshirt and
preardon
as code owners
DevJonny
pushed a commit
to DevJonny/Brighter
that referenced
this pull request
Feb 28, 2026
…erCommand#3063) * Fix some issues with schema creation in the Sqlite example * Ensure we don't commit work that is already committed on a revoke
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The revoke partitions code was generating errors because it was committing the revoked partition list. Librdkafka is telling us about the partitions that we are losing, and the commits on those partitions. So if we try to commit them again, there is nothing to commit. Instead we need to determine if we have anything in offset storage that is not in the commits, and then commit those instead.
This code fixes that.