An assortment of minor docs and spelling fixes#2733
Conversation
| public DynamoDBEntry ToEntry(object value) | ||
| { | ||
| var uuid = (Guid)value; | ||
| if (uuid == null) |
There was a problem hiding this comment.
Hard cast will throw and uuid will never be null. Changing for a version that throws the intended exception
| var uuid = (Guid)value; | ||
| if (uuid == null) | ||
| throw new InvalidOperationException( | ||
| $"Supplied type was of type {value.GetType().Name} not Accounts.Application.CardDetails"); |
There was a problem hiding this comment.
Not sure where Accounts.Application.CardDetails has come from 🤪
| .SetPartitionsRevokedHandler((consumer, list) => | ||
| { | ||
| _consumer.Commit(list); | ||
| consumer.Commit(list); |
There was a problem hiding this comment.
Presumably this was incorrectly capturing the field in the class rather than using the provided consumer
| /// <value>The no of peformers.</value> | ||
| public int NoOfPeformers { get; private set; } | ||
| /// <value>The no of performers.</value> | ||
| public int NoOfPerformers { get; private set; } |
There was a problem hiding this comment.
Renamed this property and marked the misspelt version as obsolete
|
@slang25 This looks very useful. Let us know when you are done. |
|
@slang25 How is this going? |
holytshirt
force-pushed
the
xmldocs-and-spelling
branch
from
7874ab3 to
1fb2ae7
Compare
|
@iancooper I removed the merge and rebased @slang25 change on top of latest master, so we can now pull these changes in easily |
holytshirt
requested review from
DevJonny,
holytshirt and
preardon
as code owners
|
@iancooper can you give this another review before I merge it please |
| $"Topic: {tpo.Topic} Partition: {tpo.Partition.Value} Offset: {tpo.Offset.Value}"); | ||
| var offsetAsString = string.Join(Environment.NewLine, offsets); | ||
| s_logger.LogInformation($"Sweeping offsets: {Environment.NewLine} {{Offset}}", offsetAsString); | ||
| s_logger.LogInformation("Sweeping offsets: {0} {Offset}", Environment.NewLine, offsetAsString); |
There was a problem hiding this comment.
This was deliberate, as in this case I think you do want Environment.NewLine in the message argument, and not captured as a named parameter with name 0. Although the string interpolation will probably trigger analyzers.
| | Documentation | [Technical Documentation](https://brightercommand.gitbook.io/paramore-brighter-documentation/) | | ||
| | Source |https://github.com/BrighterCommand/Brighter | | ||
| | Keywords |task queue, job queue, asynchronous, async, rabbitmq, amqp, sqs, sns, kakfa, redis, c#, command, command dispatcher, command processor, queue, distributed | | ||
| | Keywords |task queue, job queue, asynchronous, async, rabbitmq, amqp, sqs, sns, kafka, redis, c#, command, command dispatcher, command processor, queue, distributed | |
There was a problem hiding this comment.
I spell kafka like this all the time, and looking at this recent PR title, old habits die hard 😄
#3014
|
Thanks @slang25 sorry it took so long, we have been working on a new version with some big changes |
|
No worries, I had left it in draft forever so it was my bad |
* An assortment of minor docs and spelling fixes * fix(dynamo): clean merge issue and interface updates * fix(kafka): don't use string interpolation in log messages * chore(readme): fix kafka spelling * Revert redundant change --------- Co-authored-by: Toby Henderson <hendersont@gmail.com>
3 participants
No description provided.