Skip to content
This repository was archived by the owner on Feb 26, 2025. It is now read-only.

Simulation config: synapse_replay input files must be .h5#351

Merged
mgeplf merged 1 commit intomasterfrom
weji/drop_dat
Mar 21, 2024
Merged

Simulation config: synapse_replay input files must be .h5#351
mgeplf merged 1 commit intomasterfrom
weji/drop_dat

Conversation

@WeinaJi
Copy link
Copy Markdown
Collaborator

@WeinaJi WeinaJi commented Mar 11, 2024 •
edited
Loading

Following the change in BlueBrain/sonata-extension#43

  • Raise exception is "spike_file" for "spike_replay" input is not with .h5 file extension
  • Remove the "source" parameter

@WeinaJi WeinaJi changed the title Simulation config: synapse_replay input files must be .h5 and remove … Simulation config: synapse_replay input files must be .h5 Mar 11, 2024
@WeinaJi WeinaJi requested review from jorblancoa and mgeplf March 11, 2024 17:46
@WeinaJi WeinaJi mentioned this pull request Mar 11, 2024
Merged
@mgeplf mgeplf merged commit 033abe3 into master Mar 21, 2024
@mgeplf mgeplf deleted the weji/drop_dat branch March 21, 2024 08:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@joni-herttuainen joni-herttuainen Awaiting requested review from joni-herttuainen

2 more reviewers

@mgeplf mgeplf mgeplf approved these changes

@jorblancoa jorblancoa jorblancoa approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@WeinaJi @mgeplf @jorblancoa