This repository was archived by the owner on Feb 26, 2025. It is now read-only.
Conversation
mgeplf
added a commit
to BlueBrain/snap
that referenced
this pull request
Feb 1, 2024
This was referenced Feb 1, 2024
mgeplf
added a commit
to BlueBrain/snap
that referenced
this pull request
Feb 6, 2024
* work around libsonata refactor * see BlueBrain/libsonata#345
* CircuitConfig, NodeSets, and SimulationConfig didn't have a top level
docstring and thus sphinx `automodule` wasn't displaying them
* Many of the SimulationConfig were rooted in _libsonata, when they
should be in SimulationConfig; this was refactored, however it has
implications in the following projects:
* BlueCelluLab was update to work around the change
BlueBrain/BlueCelluLab#123
* SNAP tests have been updated to handle the different locations of
SimulationConfig classes:
BlueBrain/snap#254
eleftherioszisis
approved these changes
Feb 13, 2024
matz-e
approved these changes
Feb 13, 2024
Contributor
Author
|
I'm going to wait to merge this until @WeinaJi has a chance to look. |
WeinaJi
approved these changes
Feb 19, 2024
Collaborator
WeinaJi
left a comment
WeinaJi
left a comment
There was a problem hiding this comment.
Looks all good. Thank you for the improvements.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
automodulewasn't displaying thembraynscircuitstudio/fake-backend/src/api_sonata_list_populations.py?r=01bd1007809656a55239de478601cb1ac4adfc16
libsonata._libsonata.Report.Type
BlueBrain/BlueCelluLab/bluecellulab/circuit/config/sections.py?r=dbe824ac754fe878a37acf99b57d6ed968045106
from libsonata._libsonata import Conditions as LibSonataConditions