This repository was archived by the owner on Feb 26, 2025. It is now read-only.
Make sure defaults for condition blocks and others are applied#338
Merged
Make sure defaults for condition blocks and others are applied#338
Conversation
mgeplf
force-pushed
the
condition-blocks
branch
from
4712042 to
fda6c76
Compare
mgeplf
changed the title
joni-herttuainen
approved these changes
Dec 18, 2023
joni-herttuainen
left a comment
joni-herttuainen
left a comment
There was a problem hiding this comment.
It seems to me that the defaults use the values in the spec. Also: I did not realize that Simulation.network defaults to circuit_config.json. Need to change that in the validator.
jorblancoa
approved these changes
Dec 19, 2023
WeinaJi
approved these changes
Dec 20, 2023
Collaborator
WeinaJi
left a comment
WeinaJi
left a comment
There was a problem hiding this comment.
LGTM. Thanks for fixing that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.