This repository was archived by the owner on Feb 26, 2025. It is now read-only.
Conversation
Contributor
Author
|
Apparently James needs a new release of libsonata so that the metadata field is available. I'd prefer if HighFive was using a tagged version; the tests pass; but I'm not knowledgealbe about the internals enough to know if this is safe. Can someone look? |
WeinaJi
approved these changes
Jun 23, 2023
Collaborator
WeinaJi
left a comment
WeinaJi
left a comment
There was a problem hiding this comment.
Looks good on the neurodamus side. I've built neurodamus with this branch and the simulation works as usual.
Collaborator
|
Tag @alkino for review |
alkino
approved these changes
Jun 23, 2023
Contributor
Author
|
Great, thanks everyone. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.