Migrated ViewPropTypes to deprecated-react-native-prop-types #119
Closed
madhus1025 wants to merge 2 commits intoBigThinkcode:fork-mainfrom
Closed
Migrated ViewPropTypes to deprecated-react-native-prop-types #119madhus1025 wants to merge 2 commits intoBigThinkcode:fork-mainfrom
madhus1025 wants to merge 2 commits intoBigThinkcode:fork-mainfrom
Conversation
This, used on line 53 of the file edited here, is also deprecated and needs the same fix, i've not checked any other others update: Also the react-native-video dependency has the same issue, it has a point version patch, 5.2.1, with the same fix proposed here so that should be set to the min That assumes this is the fix the repo manager want to go with |
|
@madhus1025 This change looks fine to me. Can you just add deprecated-react-native-prop-types to the dependencies in package.json Meanwhile we are also changing prop-types in other places in the code and dependencies. As @cameroncharles mentioned, the react-native-video is also upgraded and will be released in next build. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
View PropTypes is deprecated, need to migrate to another library
facebook/react-native#33557
Description
ViewPropTypes is deprecated and we have to migrate to deprecated view prop types untill we completely eliminate it.
Sample Card
NA
How Verified