chore: remove leftover PR_POLICY_BODY.md after #939 - #953
Merged
Conversation
Same class of issue as #942: a merged PR left PR_POLICY_BODY.md on main, so Sync PR policy body would re-apply a stale description to later PR heads that still carry the file from main. Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
Contributor
|
Important Review skippedReview was skipped as selected files did not have any reviewable changes. 💤 Files selected but had no reviewable changes (1)
⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
cursor Bot
pushed a commit
that referenced
this pull request
Jul 25, 2026
#1177) * fix(#30): keep admission/discharge wide-tier aliases disjoint A single Admission-to-Discharge document was listed under both AdmissionCommunityPts and Discharge, so expectedFileCoverage could set allHit true from one retrieved source. Drop those titles from the admission side and add fail-closed contract tests. Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com> * fix(#75): paginate search-scope label enumeration past 1k rows A single document_labels query could silently drop matches beyond the Supabase 1,000-row response cap. Load labels in deterministic document-batched pages with stable ordering and abort propagation, and cover multi-page >1000 enumeration in unit contracts. Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com> * issues: mark #30 and #75 done Archive the wide-tier dual-alias false-pass and search-scope 1k label truncation fixes; remove the composite recommended-queue row. Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com> * fix: harden distinct-slot matching and label page budget expectedFileCoverage now consumes each retrieved top-file at most once so a combo-titled source cannot false-pass multi-slot allHit. Label enumeration fails closed after a bounded page budget instead of looping forever on a stuck full-page API response. Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com> * style: prettier-format search-correctness follow-up files Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com> * ci: sync accurate PR #1177 policy body template Replace the stale search-performance PR_POLICY_BODY.md leftover on main so Sync PR policy body stops overwriting this PR with unrelated summary text. Template will be deleted in a follow-up commit after the sync job applies it. Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com> * ci: apply correct PR #1177 policy body for sync Temporary template so Sync PR policy body replaces the stale search-performance description. Delete in the next commit before merge. Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com> * ci: remove PR_POLICY_BODY.md after sync Keep the corrected GitHub PR description without leaving a template on main that would overwrite later PR bodies (same cleanup pattern as #942 / #953). Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com> * docs: record PR #1177 review and hardening outcome Append branch-review-ledger entry for the #30/#75 assessment, distinct-slot/page-budget fixes, and PR_POLICY_BODY cleanup. Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com> * docs: supersede #1177 ledger tip after PR_POLICY_BODY cleanup Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com> * fix(docs): encode ledger em-dashes as UTF-8 Co-authored-by: Cursor <cursoragent@cursor.com> --------- Co-authored-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
12 tasks
cursor Bot
pushed a commit
that referenced
this pull request
Jul 25, 2026
…mplate cleanup (#1204) * fix(#30): match expected files by distinct document identity The merged #30 fix assigned each expectation to a distinct source position. Positions are not documents: answer.citations carries one entry per cited chunk, so a single combo-titled document arrives several times and could still fill both comparison slots. First-come assignment was also order-dependent -- a document matching two expectations could consume the only source a narrower expectation needed, so the same inputs produced different allHit results depending on expectedFiles order. Dedupe the window by document text and assign sources by maximum bipartite matching, so coverage is both distinct-by-document and order-independent. RAG impact: no retrieval behaviour change -- eval matching only. Also append label rows in place when building labelsByDocument; paging past the 1,000-row cap (#75) means that loop now sees the full label set, where per-row array rebuilds were quadratic. Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com> * chore: remove leftover PR_POLICY_BODY.md after #1153 The sync-pr-policy-body CI job overwrites a pull request description with this file whenever it exists on the head commit. The copy on main holds the audit-remediation body from #1153, so every branch cut from main silently inherits that description -- which is how #1177 lost its own body. Remove it, as #953 did after #939; the job skips cleanly when no template is present. Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com> * docs(issues): record the #30 follow-up and open #80 Drop the stale queue row for #30/#75, which stayed in the recommended queue after both were archived, note the distinct-identity hardening on the #30 archive row, and open #80 to re-test the removed admission-to-discharge widening under approved eval evidence. Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com> * docs(ledger): append #1177 SHA correction and this review record Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com> --------- Co-authored-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#939 squash-merged with
PR_POLICY_BODY.mdstill on the head, so the file is back onmain. Sync PR policy body will re-apply that stale compare-dock description to later PR heads that inherit the file (same failure mode as #942).Delete the leftover template from
main.Verification
PR_POLICY_BODY.mdRisk and rollout
main.PR_POLICY_BODY.mdfrom test(ui): poll compare-dock pointer hit after reveal transition #939 if a future PR intentionally needs the sync file on its feature branch only.