fix(access): add document_read and document_upload rate-limit buckets - #297
Conversation
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 2 potential issues.
Bugbot Autofix prepared fixes for both issues found in the latest run.
- ✅ Fixed: Note parsing misses en-dashes
- Restored proper Unicode en-dashes (·, –, …) in clinical note parsing regexes, detail-prefix checks, and related display strings that had been corrupted to mojibake.
- ✅ Fixed: Sentinel skips mobile table content
- Moved the below-content sentinel to after InlineTableCard (with lg:col-span-2) so mobile collapse logic detects unscrolled table content below the support action row.
You can send follow-ups to the cloud agent here.
Reviewed by Cursor Bugbot for commit c7f2d68. Configure here.
| return title; | ||
| } | ||
| const dashIndex = text.search(/\s[-–]\s/); | ||
| const dashIndex = text.search(/\s[-ΓÇô]\s/); |
There was a problem hiding this comment.
Note parsing misses en-dashes
Medium Severity
A character encoding issue caused special characters (en-dashes, em-dashes, middle dots, ellipses) to render as mojibake (–, —, ·, …). This impacts clinical note parsing logic, lithium timing heuristics, and visible text in context strips, evidence summaries, and source details.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit c7f2d68. Configure here.
| data-testid="answer-support-below-sentinel" | ||
| className="h-0 w-0" | ||
| aria-hidden="true" | ||
| /> |
There was a problem hiding this comment.
Sentinel skips mobile table content
Medium Severity
The below-content sentinel is positioned before the InlineTableCard, which causes useCollapseWhenContentBelow to misjudge available scrollable content. As a result, the Clinical notes/Evidence support row remains expanded even when a large table is still off-screen, particularly on mobile, potentially overlapping with fixed UI elements.
Reviewed by Cursor Bugbot for commit c7f2d68. Configure here.
Four rows, all measured against origin/main 199b303 in this session: - #295 (P2 task) the ErrorState enforcement check. GATES.md:106 still reads "planned" and grep over scripts/ and eslint-rules/ returns zero references to ErrorState, so the component exists but nothing requires it. Deliberately not flipped to implemented. - #296 (P3 task) adopting ErrorState at the three surfaces that genuinely hand-roll the guard. Live-look change, downstream of the redesign. - #297 (P3 issue) the safe-area exemption in the new raw-value ratchet, which is by form rather than by absence of a literal. - #298 (P2 issue) the three sites carried into M4 as guards that are not guards, so the next reader does not convert them. Written with npm run issues:add, never by hand. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Q5u4VXpSFGfucKWwSBtdtd
* refactor(design-system): retire the dead --text-2xl-compact type step `--text-2xl-compact` was declared in the globals.css `@theme` block and selected by zero production surfaces — the one step the new declared-but-unconsumed gate found on the day it landed, carried since as the only entry in `UNUSED_TYPE_STEP_EXEMPTIONS` with its retirement tracked as outstanding-issues `#297`. Deleting a step nothing selects renders identically, so this is a no-op for users; it is isolated in its own commit because it edits `@theme`. - delete the declaration from `src/app/globals.css` - drop `2xl-compact` from `CLINICAL_TWMERGE_THEME.text` and its docstring (the paired test asserting the config tracks globals.css keeps the two lists honest) - drop `text-2xl-compact` from `CUSTOM_TEXT_STEPS` - delete the exemption entry; the Map is now empty, which its header records as the intended resting state - repoint the one synthetic `var(--text-2xl-compact)` test fixture at `--text-2xl-minus` so no fixture names a token that no longer exists - TOKENS.md legacy-step row and GATES.md (eight steps, not nine — the 705-consumer total is unchanged because this step contributed 0) - close `#297` in the outstanding-issues ledger Verified: check:design-system-contract passed (705 production files), check:type-scale --strict passed, lint and typecheck exit 0, and the full offline unit suite is 5993 passed with one pre-existing environment failure in tests/pr-handoff-stop.test.ts that reproduces unchanged on the clean tree (it chmods a directory to 0555 to force a write failure, which root ignores). Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Q5u4VXpSFGfucKWwSBtdtd * docs(ledger): record the #297 type-step retirement review Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Q5u4VXpSFGfucKWwSBtdtd --------- Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: Cursor Agent <cursoragent@cursor.com>
1 participant
Summary
Dedicated access-hardening for document read and upload API routes (split from the closed auto-hide PR #284).
document_readbucket (180/min authenticated, 45/min anonymous) viaenforceDocumentReadRateLimit()on document list/detail/search/signed-url and image signed-url routes.document_uploadbucket (12/min authenticated) on/api/uploadbefore storage or database work.allowRateLimitInMemoryFallbackOnUnavailable()onapi-rate-limit.tsfor production-safe fallback parity with other public routes.cursor/fix-all-db-issues-5f13.Verification (local)
npx vitest run tests/private-access-routes.test.ts -t "rate limits anonymous document read bursts|rate limits authenticated uploads before" --testTimeout 60000— passedmain/release/**; this PR targetscursor/fix-all-db-issues-5f13.Clinical governance preflight