Skip to content

Record the post-merge verification for the Sources browse redesign - #2598

Merged
BigSimmo merged 4 commits into
mainfrom
claude/ledger-prlanded-2593
Sep 4, 2026
Merged

Record the post-merge verification for the Sources browse redesign#2598
BigSimmo merged 4 commits into
mainfrom
claude/ledger-prlanded-2593

Conversation

@BigSimmo

@BigSimmo BigSimmo commented Sep 4, 2026

Copy link
Copy Markdown
Owner

Summary

  • One append-only branch-review record for the post-merge verification of #2593 (Sources Topics/Publishers browse redesign), written by npm run ledger:append --scope prlanded. No canonical ledger table row is touched, and no other file changes.
  • Give Sources' Topics and Publishers the chrome the Catalogue already has #2593 was merged with a merge commit while a second session was pushing 87b1d5e to the same branch, so it is exactly the auto-merge race prlanded exists to catch. The record states what was verified by content rather than by ancestry alone: all seven branch commits are ancestors of origin/main; the eight changed files are byte-identical between branch tip 87b1d5e and main; and git diff 87b1d5e 0f85b91 is empty, so the merge took the branch tree wholesale and orphaned nothing. The remote branch was deleted on merge, so no late commit can be stranded behind it.
  • The record also carries the post-merge evidence and the honest gaps: 102 unit tests green on merged main under TZ=America/Los_Angeles, the pre-merge focused browser proof, and the explicit note that verify:ui and verify:pr-local were never run locally.

Verification

  • npm run check:ledger-write-disciplineLedger write discipline passed for 0f85b916d62d..HEAD. (self-test passed first). This is the gate that governs this change.

  • npm run check:branch-review-ledgerBranch review ledger guard passed: 880 live table records + 1206 archived + 604 immutable (880 under the 2026-07-29 machine-readable contract), immutable review writes, six cells each, no conflict markers, mojibake, heading records, or duplicates.

  • npm run ledger:append wrote the record; the file is the tool's own output, committed unedited.

  • npm run verify:pr-local

  • npm run verify:ui

Verification not run: verify:pr-local was not run. UI verification not run: the diff is a single generated Markdown record under docs/branch-review-records/, with no source, route, style or browser surface in it — classifyPullRequestFiles returns clinicalRisk: false, ui: false, ragRanking: false, migration: false, operationalRisk: false. The two ledger gates above are the checks that actually apply.

Notes

  • Append-only by design: docs/branch-review-ledger.md and docs/outstanding-issues.md are serial-only, and a normal PR must not add rows to either. This adds one immutable record file and nothing else, which is the sanctioned route.
  • Content of the record is a verification report, not a claim of new work. The code it describes is already on main as 0f85b91.

🤖 Generated with Claude Code

https://claude.ai/code/session_01Sh8qHzezbEjWGp4MGJtjyk


Generated by Claude Code


Note

Low Risk
Documentation-only append to immutable review records; no runtime, auth, or data-path changes.

Overview
Adds a single append-only immutable row under docs/branch-review-records/ (via ledger:append / prlanded) documenting post-merge verification for PR #2593 — no application code, routes, or canonical ledger table edits.

The record captures the merge-commit race check (branch tip 87b1d5e vs merged 0f85b91: empty tree diff, byte-identical changed files, remote branch deleted) and what was actually run: 102 related unit tests on main, focused Chromium UI specs and verify:cheap on the branch, with explicit gaps (verify:ui, verify:pr-local not run locally; three shallow-clone verify:cheap failures called out as base artefacts).

Reviewed by Cursor Bugbot for commit 3b35ed2. Configure here.

Content-verified that the Sources browse redesign landed on main as 0f85b91:
every branch commit is an ancestor of main, the eight changed files are
byte-identical between the branch tip and main, and the branch-tip-to-merge
tree diff is empty, so the auto-merge race orphaned nothing.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Sh8qHzezbEjWGp4MGJtjyk
@coderabbitai

coderabbitai Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Team

Run ID: a8778b10-3b29-4516-8191-faa95cbe5928


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 4, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-04T07:49:35.327227Z 1d39483 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@cursor

cursor Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: serverGenReqId_d0f4e453-997c-43c4-a4dc-d3184680e883)

@supabase

supabase Bot commented Sep 4, 2026

Copy link
Copy Markdown

This pull request has been ignored for the connected project sjrfecxgysukkwxsowpy because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.


Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

@cursor

cursor Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: serverGenReqId_3fe5bbbd-c6b0-4e72-a0b6-c7520b7b7000)

@BigSimmo
BigSimmo enabled auto-merge (squash) September 4, 2026 11:05
@BigSimmo
BigSimmo merged commit be5fa23 into main Sep 4, 2026
27 checks passed
@BigSimmo
BigSimmo deleted the claude/ledger-prlanded-2593 branch September 4, 2026 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants