docs(ledger): record the post-merge verification of PR #2543 - #2578
Conversation
prlanded on claude/mockup-retirement-xw0vmn. The squash landed as 374a560 and the content diff against the branch tip 4877a2e is empty, so nothing was orphaned by the auto-merge race. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015UPvNZYvyuDxc1o7xfTGCS
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Team Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_aa0b67c8-0d4b-4613-9c20-125293024960) |
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_73a109bd-430c-42fb-8c7a-b60e023671d5) |
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_e1a1124b-17d1-4ce5-a37d-571f4197518f) |
Summary
claude/mockup-retirement-xw0vmn, scopeprlanded, created bynpm run ledger:append. No other file changes.374a5603. Theprlandedcheck that matters here is content, not ancestry:git diff --stat 374a5603 4877a2e4is empty, so every commit on the branch tip reachedmainand the auto-merge race orphaned nothing. That race has cost this repo a fix-forward before, which is why the record states the comparison rather than just the merge.--headis the full 40-character squash SHA, not the branch tip, per theprlandedskill.Verification
npm run check:branch-review-ledger—880 live table records + 1206 archived + 589 immutable (880 under the 2026-07-29 machine-readable contract), immutable review writes, six cells each, no conflict markers, mojibake, heading records, or duplicatesnpm run check:ledger-write-discipline—Ledger write discipline passed for 705c2f64a788..HEADorigin/mainat705c2f64, carrying exactly one appended record and no canonical-ledger edit.Verification not run:
npm run verify:pr-local— the diff is a single addeddocs/branch-review-records/*.record.mdfile with no executable scope. The two gates above are the ones that govern this file, and both are green..prettierignoredeliberately excludesdocs/branch-review-records/, because the filename is the SHA-256 of the row and reformatting breaks its own guard.UI verification not run: no UI, routing, or styling surface is touched.
Not run: any provider-backed gate. None applies.
Risk and rollout
git revertthe single commit, or delete the record file.Notes
Recorded outcome, verbatim from the row:
Two things the record deliberately preserves rather than rounds off:
check:dead-code-candidaterefused that diff and is recorded as refusing. 64 of 201 candidates, every one a bare-symbol-name collision on a file-local identifier. No threshold and no refusal-list entry was changed to make it pass — the point of PR chore(cleanup): remove unused exports and add a dead-code safety gate #2204's post-mortem was that the diff yields to the gate, never the reverse.Advisory UIfailed on several intermediate heads and was not this PR's.rankToolRecords("Risk & Safety")returned 3 where the test asserted 1, on catalogue files the branch never touched. Assert the ranking, not a tool count the Tools search mockup has rotted twice #2554 fixed it onmainindependently, and the lane is green on the merged head.🤖 Generated with Claude Code
https://claude.ai/code/session_015UPvNZYvyuDxc1o7xfTGCS
Generated by Claude Code
Note
Low Risk
Append-only documentation under the branch-review ledger; no runtime, UI, or security-sensitive code paths change.
Overview
Adds one immutable append-only row in
docs/branch-review-records/(vialedger:appenddiscipline), with no other file changes.The record documents post-merge verification for branch
claude/mockup-retirement-xw0vmnafter #2543 landed as squash374a5603. It states the content diff from that squash to branch tip4877a2e4is empty (no orphaned commits), summarizes the merged work (policy +check:mockupsgate and seven mockup retirements), and captures CI/local gate outcomes—including thatcheck:dead-code-candidaterefused the original diff and was recorded without tuning thresholds.Reviewed by Cursor Bugbot for commit ae00f06. Configure here.