Add governed clinical Sources catalogue - #2510
Conversation
️✅ There are no secrets present in this pull request anymore.If these secrets were true positive and are still valid, we highly recommend you to revoke them. 🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request. |
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_7cc92270-782c-4e7d-a9d6-6b4ab2aa6c86) |
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Team Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a83e4245f3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Resolve conflicts: prefer main for repo-awareness snapshot and dependency surface; keep Sources mode changes; redact GitGuardian basic-auth fixture.
Squash rewrite onto current main to drop historical GitGuardian basic-auth fixture from PR commit range while keeping tip content (credential URL built via URL API placeholders).
da1108d to
075ff1f
Compare
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_36548b20-d0b0-4185-a347-4961f3a28f24) |
7584bc7 to
f159844
Compare
|
PR unblock summary
|
Summary
Verification
npm run verify:pr-localformat:changed; runtime and installed-lock parity passed, and later stages did not run. Formatting was repaired and passed separately, but this broad gate was not rerun.npm run verify:uiwhen UI, routing, styling, browser behavior, reduced-motion, or forced-colors behavior changednode scripts/run-playwright.mjs tests/ui-sources.spec.ts --project=chromium— 3 passed. No post-hardening browser rerun.npm run verify:releasebefore release or handoff confidence claimsnpm run eval:retrieval:quality(must stay 36/36) when retrieval, ranking, selection, chunking, or scoring behavior changednpm run eval:rag -- --limit 15+npm run eval:quality -- --rag-onlywhen answer generation, the synthesis prompt, or answer post-processing changednpm run check:production-readinesswhen clinical workflow, privacy, environment, Supabase, source governance, or deployment behavior changednpm run check:deployment-readinesswhen deployment startup, hosting, or rollout behavior changedFocused evidence:
node scripts/run-vitest.mjs run tests/source-url-policy.test.ts tests/source-catalogue-core.test.ts tests/source-catalogue-providers.test.ts tests/sources-mode.dom.test.tsx— 86 passed.npm run check:source-catalogue— passed; 1,529 references, 692 canonical sources, 692 D-band review-debt entries, 0 invalid current provider dates.npm run docs:check-index,npm run docs:check-inventory,npm run sitemap:check, andnpm run check:repo-awareness-snapshot— passed.Risk and rollout
Clinical Governance Preflight
Clinical KB Database(sjrfecxgysukkwxsowpy)Notes
Note
Medium Risk
New routes expose aggregated source metadata and document visibility rules; mistakes could leak private document identity or misrepresent governance, though the design is read-only with server assembly and conservative review-debt handling.
Overview
Introduces a read-only Sources application mode at
/sourceswith catalogue, Topics, Publishers, Method, and per-source detail routes. The catalogue is assembled on the server from registered production content providers plus owner/public-scoped indexed document metadata, then normalized into client-safe entries with deterministic quality bands, filters, and usage traceability.Navigation and compatibility: Sources is wired as the 16th app mode (functional home at
/sources, sidebar “More modes”, secondary nav Catalogue · Topics · Publishers · Method)./dictionary/sourcesbecomes a query-preserving redirect to/sources?usedBy=dictionaryinstead of a Dictionary-only page.Supporting changes: New
src/lib/sources/stack (catalogue core/view, repository providers, document loader),npm run check:source-catalogue, DOM andtests/ui-sources.spec.tsbrowser proof, and updates to repo-awareness snapshot, site map, design-system adoption contract, and codebase index. Presentation-only catalogue rating; RAG/retrieval paths are not modified in this diff.Reviewed by Cursor Bugbot for commit 3561ce5. Configure here.