Skip to content

fix(tooling): execute PR group 1 tooling, CI/CD, scripts, and governance sweep - #2476

Merged
BigSimmo merged 19 commits into
mainfrom
tooling_ci_governance_sweep
Aug 31, 2026
Merged

fix(tooling): execute PR group 1 tooling, CI/CD, scripts, and governance sweep#2476
BigSimmo merged 19 commits into
mainfrom
tooling_ci_governance_sweep

Conversation

@BigSimmo

@BigSimmo BigSimmo commented Aug 31, 2026

Copy link
Copy Markdown
Owner

Summary

Executes PR Group 1 tasks across tooling, CI/CD, scripts, documentation, and repository governance:

  • #ZM8902: Enhanced scripts/check-docs-links.mjs to parse and validate GitHub-flavored markdown heading slugs and HTML anchor tags (<a id/name>, <span>). Included docs/superpowers/specs/ in scanning and fixed broken spec links. Added unit tests in tests/check-docs-links.test.ts (4/4 passed; 4,717 repo references verified).
  • #TBW7BR: Updated AGENTS.md lines 422–427 to accurately document scripts/run-playwright.mjs exit codes (exit 75 on lock/admission contention, exit status propagation on test failure, exit 1 on wrapper/build error).
  • #CTA8CR: Updated docs/audit/live-drift-forensics-2026-08.md line 2276 to record that manual promotion recommendations are superseded per settled policy §D4 (deploy-on-merge ON).
  • #JFRCZ4: Enhanced scripts/check-repo-awareness-snapshot.ts with checkRepoAwarenessSnapshot() to gracefully skip git-less environments with exit 0 and an informative warning (10/10 unit tests passed in tests/repo-awareness-gate.test.ts).
  • #W53DY5: Added diagnostic logging in scripts/run-playwright.mjs on non-zero Next.js production build exits (capturing status, signal, error, and process memory RSS/heap).
  • #XHNTHD: Added --allow-partial CLI flag and resolveEvaluationCases() fail-safe in scripts/eval-retrieval.ts preventing zero-case runs or silent case drop without explicit opt-in (28/28 unit tests passed in tests/eval-retrieval.test.ts).
  • #Y0BDBJ: Added measureServerHtmlPayloads() in scripts/check-bundle-budget.mjs and configured serverPages ceiling in bundle-budget.json to monitor unpaginated server-rendered HTML payloads (67/67 unit tests passed in tests/bundle-budget.test.ts).
  • #DVRZA4, #XHADPV, #5YKAQ5, fix: reconcile redesign and restore lint #23, #2DQXD8, #RVK6BJ: Grounded against main and verified resolved/safe, with merge-safe ledger closure entries queued in docs/outstanding-issues-inbox/.

Verification

  • npm run typecheck — 0 errors across 5,866 repository files.
  • npx vitest run tests/check-docs-links.test.ts tests/repo-awareness-gate.test.ts tests/eval-retrieval.test.ts tests/bundle-budget.test.ts — 4/4 test suites passed, 109/109 tests passed.
  • node scripts/check-docs-links.mjs — 4,717 repo path and anchor links verified.
  • npx tsx scripts/check-repo-awareness-snapshot.ts — in step with data/repo-awareness-snapshot.json.
  • UI verification not run: No UI components or frontend rendering touched; tooling, validation scripts, and docs only.

Risk and rollout

  • Risk: Low operational risk; scoped tooling, documentation, and validation scripts only.
  • Rollback: Revert merge commit via standard git revert.
  • Provider or production effects: None.
  • RAG impact: no retrieval behaviour change — added CLI flag --allow-partial and fail-safe for empty case sets in eval harness

Clinical Governance Preflight

  • Source-backed claims still require linked source verification before clinical use
  • No patient-identifiable document workflow was introduced or expanded without explicit governance approval
  • Supabase target remains Clinical KB Database (sjrfecxgysukkwxsowpy)
  • Service-role keys and private document access remain server-only
  • Demo/synthetic content remains clearly separated from real clinical sources
  • Source metadata, review status, and outdated/unknown-source behavior remain conservative
  • Deployment classification/TGA SaMD impact was checked when clinical decision-support behavior changed

Note

Low Risk
Changes are mostly offline CI/scripts and docs; eval harness stricter defaults could break ad-hoc partial runs until --allow-partial is passed; UI edits are presentation-only on account setup and retrieval banners.

Overview
This PR is a tooling and governance sweep plus a few targeted product tweaks. Validation scripts get stricter and more testable; docs and ledgers catch up with settled policy.

Docs links now validate in-repo markdown anchors (heading slugs and HTML id/name), not just file paths. Bundle budget adds serverPages ceilings via measureServerHtmlPayloads() so large server-rendered pages (starting with /mockups/development/review-state) cannot grow without failing check:bundle-budget. Eval retrieval gains --allow-partial and resolveEvaluationCases() so empty or silently truncated golden runs fail closed unless explicitly opted in. Repo-awareness exposes checkRepoAwarenessSnapshot() and skips with exit 0 when git is unavailable. Playwright wrapper docs in AGENTS.md are corrected; build failures log memory/status diagnostics in run-playwright.mjs.

Smaller follow-ons: stale-evidence retrieval banner renders as a compact inline group (not the bordered card used for other states); OAuth provider buttons use !min-h-[48px] for ui-smoke tap targets; ward-flow spec path updated to mockups/ward-flow; drift audit note marks superseded D4 guidance; snapshot and outstanding-issue inbox housekeeping.

Reviewed by Cursor Bugbot for commit 69e24d1. Configure here.

BigSimmo and others added 11 commits August 27, 2026 14:10
Remaining Lucide size={15} and 1px shadow spreads were blocking the
token contract. Map those to named tokens, drop unused v2 line-height
companions, and record leftover Hazard 2/3 items in FIX-GUIDE.

Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>

# Conflicts:
#	src/components/therapy-compass/therapy-card.tsx
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Keep quoted contract numbers in lockstep with the baseline JSON, and replace nested brief-duration ternaries plus leftover Lucide size={16} on screens this sweep already touched.

Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@supabase

supabase Bot commented Aug 31, 2026

Copy link
Copy Markdown

This pull request has been ignored for the connected project sjrfecxgysukkwxsowpy because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.


Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

@coderabbitai

coderabbitai Bot commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 3860a197-863e-4b4b-bd92-3aa105748e53


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Aug 31, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-08-31T03:28:17.188492Z dc540ed PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@cursor

cursor Bot commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: serverGenReqId_15712a3a-b055-4bc7-b988-86bd71e509ef)

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: dc540ed9c2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread scripts/check-bundle-budget.mjs
Comment thread scripts/check-bundle-budget.mjs
@github-actions

github-actions Bot commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

CI triage

CI failed on this PR. Automated classification of the 3 failed job(s):

  • Lighthouse budgetneeds investigation: inspect the failing step and uploaded diagnostics; rerun only after classifying the cause.
  • Production UI (1)needs investigation: inspect the failing step and uploaded diagnostics; rerun only after classifying the cause.
  • PR requiredneeds investigation: inspect the failing step and uploaded diagnostics; rerun only after classifying the cause.

Compared with main CI run #14557 (failure).

Classification is evidence routing, not permission to ignore a failure. Exact quarantined Playwright identities remain governed by the flake ledger.

BigSimmo and others added 3 commits August 31, 2026 11:52
Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
Rem-based min-h-tap/min-h-12 undershoot under compact density (15px root)
and can subpixel-round below the ui-smoke account-provider assertion.

Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
@cursor

cursor Bot commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: serverGenReqId_b59bdcd7-4621-4b5b-a90f-3b1c30122c57)

@BigSimmo
BigSimmo enabled auto-merge (squash) August 31, 2026 04:50
@BigSimmo
BigSimmo merged commit 980a48a into main Aug 31, 2026
29 checks passed
@BigSimmo
BigSimmo deleted the tooling_ci_governance_sweep branch August 31, 2026 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants