Skip to content

feat(answer): compose follow-up chips from the S2 menu, gate them on evidence (packet S3 / A4) #2108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BigSimmo merged 4 commits into from
Aug 18, 2026
Merged

feat(answer): compose follow-up chips from the S2 menu, gate them on evidence (packet S3 / A4) #2108

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b0544fc
feat(answer): compose follow-up chips from the S2 menu, gate them on …
BigSimmo Aug 18, 2026
48e6e9b
chore(ledger): record the packet S3 review (claude/s3-follow-up-sugge…
BigSimmo Aug 18, 2026
c954250
docs(rag): fill the packet S3 PR number (#2108) in the HANDOVER statu…
BigSimmo Aug 18, 2026
3d28816
Merge branch 'main' into claude/s3-follow-up-suggestions-95e160
BigSimmo Aug 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ...ords/cc149b75e900816f35298154ab35a6e553ac49a88cacbd0b7ea4de568250259a.record.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
| 2026-08-18 | claude/s3-follow-up-suggestions-95e160 | b0544fcafaf9effad83b3a379e580ccf68c921fa | packet S3 / A4: menu-derived, evidence-gated follow-up chips in src/lib/answer-follow-up.ts + focused unit and DOM proof | Approved - deterministic composition only; candidates come from the S2 related-information menu, gated on retrieved evidence, suppressed when the answer or an emitted section of that kind already covers them; no src/lib/rag edit, no ClinicalDashboard change, no new module/field/render block; generation prompt untouched | answer-follow-up 27/27; answer-follow-up-chips DOM 6/6; answer-composition 9/9; lint; typecheck; build compiled 2.6min + client bundle secret check; eval:rag:offline 26 suites/623 tests (36 golden cases); eval:rag:adversarial:offline 25/25; check:medication-interactions; check:medication-lexicon-report; full unit suite 7079 passed / 8 failed in 6 unrelated files - session-start-hook reproduced at merge base e1749bf8d, the other five pass in isolation on this branch (Windows parallel-load timeouts) |
6 changes: 6 additions & 0 deletions docs/rag-behaviour/behaviour-map.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,3 +134,9 @@ answerShape}` where `answerShape` is provider-safe counts/lengths only — never
ladder apply to menu sections unchanged. Contract pins: `tests/answer-composition.test.ts`
(all 48 class×intent cells), `tests/rag-answer-composition-prompt.test.ts`,
`tests/rag-answer-fallback.test.ts` (menu line in the real prompt input).
- Downstream consumer (packet S3, 2026-08-18): `src/lib/answer-follow-up.ts` reads the same menu to
compose the answer surface's follow-up chips — menu-derived candidates, gated on the retrieved
evidence the client actually received, and suppressed when the answer body or an emitted section of
that kind already covers them. It only READS the menu and changes no retrieval, ranking or prompt
surface. Its templates are index-aligned with the menu items, asserted over all 48 cells in
`tests/answer-follow-up.test.ts`, so a menu edit fails offline instead of silently dropping a chip.
Loading
Loading