Fix mobile overflow on Forms information page - #1986
Conversation
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe form information disclosure group now shrinks within its grid container. A Playwright regression test checks disclosure-row containment at 320, 390, and 639 pixel viewport widths. ChangesForm viewport containment
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to The change constrains disclosure content to remain within mobile viewports without altering desktop or print behavior, and the focused regression test passed. No actionable merge-blocking risk remains. Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
ESLint install failed: dependency version conflict. Check your lock file or package.json. Comment |
Codex review-and-fix summary
Codex did not merge or modify auto-merge. The existing merge workflow completed the PR. |
Motivation
Description
min-w-0to theDisclosureGroupwrapper so its children may shrink: updatesrc/components/forms/form-detail-page.tsx(wrapDisclosureGroupwithclassName="min-w-0").320,390, and639px: updatetests/ui-forms-section-nav.spec.tswithkeeps information rows inside the mobile viewport.Testing
npm run test:e2e:critical -- tests/ui-forms-section-nav.spec.ts --project=chromium --grep "keeps information rows"and the new test passed (1 passed).npm run formatandgit diff --checkto ensure formatting and no diff-check failures, both completed successfully.curl http://localhost:3131/api/local-project-idand inspected the rendered page with Playwright at390px(screenshot taken) to verify no horizontal overflow on mobile viewports.Codex Task
Summary by CodeRabbit
Bug Fixes
Tests