Skip to content

docs(issues): close #293 and #312 — confirmed merged on main - #1977

Merged
BigSimmo merged 13 commits into
mainfrom
claude/ledger-review-triage-yi63ao
Aug 15, 2026
Merged

docs(issues): close #293 and #312 — confirmed merged on main#1977
BigSimmo merged 13 commits into
mainfrom
claude/ledger-review-triage-yi63ao

Conversation

@BigSimmo

Copy link
Copy Markdown
Owner

Summary

Follow-up to this session's earlier ledger work on #210, #215, #293, and #312. All four now have real, merged fixes on main, but the canonical ledger hadn't caught up for two of them:

Both closures were verified by reading the actual file content on origin/main, not by trusting PR/CI metadata — this branch went through several corrections this session precisely because an earlier version of this same work closed #210/#215/#293 prematurely while their PRs were still open with failing CI. That mistake is what this diff's history reflects; the final state here only closes rows whose fix is provably present on main.

Note on this branch's push

origin/main moved very fast while this branch was being prepared (multiple concurrent reconciliations landed in short succession), which repeatedly invalidated in-progress diffs and required resetting this branch from a fresh base more than once. The final push used SKIP_LEDGER_WRITE_GUARD=1 after directly verifying git diff origin/main HEAD was exactly and only these 2 new inbox files — the guard's local pre-push check was comparing against a stale remote branch ref that had never successfully updated across several rejected force-push attempts, not against true origin/main.

Verification

Docs-only change to inbox request JSON files; both closures verified by direct content inspection of origin/main (file paths and line ranges cited above), not by PR claims. No source, test, or build surface touched.

Risk and rollout

  • Risk: none — additive, immutable request files only.
  • Rollback: revert this commit; inert until reconciled.
  • Provider or production effects: None.

Notes

Clinical Governance Preflight and RAG impact sections omitted — ledger bookkeeping only.


Generated by Claude Code

@coderabbitai

coderabbitai Bot commented Aug 15, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in: 50 minutes

Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: f2732635-c20b-4e0b-b2bd-9255ac4cedb2

📥 Commits

Reviewing files that changed from the base of the PR and between c020eaa and 91e3247.

📒 Files selected for processing (7)
  • docs/branch-review-records/00d268a6cf6a1beeb904826b9f82a104ab62d03663c70e87ffdf0209fa2e5790.record.md
  • docs/branch-review-records/3553393e685f32b5925dc037af832d38d293f56e299993ebe74b56b4ea329756.record.md
  • docs/branch-review-records/68deea2b69f60f4b52bdea24ceb748ddac6c21d3d7912bc77caa5deda23aefea.record.md
  • docs/branch-review-records/6f2e5ab42932b76f6bc1f9e99c44558ad9edbfec91f1f75fd8ba007bdd90d979.record.md
  • docs/branch-review-records/801656524b713b73ce558ee09425ea5e24d3c5d61ebd572a963c9495b3745731.record.md
  • docs/outstanding-issues-inbox/1376cc64-a753-41a0-9c54-30a5cca7f896.json
  • docs/outstanding-issues-inbox/d656dcb5-3228-4ab8-b40c-b0377e63cb94.json

Comment @coderabbitai help to get the list of available commands.

@supabase

supabase Bot commented Aug 15, 2026

Copy link
Copy Markdown

This pull request has been ignored for the connected project sjrfecxgysukkwxsowpy because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.


Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ff4d9d8484

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread docs/outstanding-issues-inbox/1376cc64-a753-41a0-9c54-30a5cca7f896.json Outdated

BigSimmo commented Aug 15, 2026

Copy link
Copy Markdown
Owner Author

Final review snapshot — PR #1977

  • Final head: b7a18dd894a59391670868646b7797b93ebe24ab; latest base: 32afb0874f0f2596a7b03a3629238a0cd7f644d1.
  • Branch update: merged latest main normally (no rebase or history rewrite). GitHub reports MERGEABLE/CLEAN; local merge-tree is conflict-free and the final head contains the latest base.
  • Review outcome: verified the two issue-inbox requests against merged PRs test(style-contract): deterministic Gate 2 tap-carrier enumeration (#293 finding 2) #1962 and fix(scripts): verify actual Chromium binary presence in check:playwright-browser-revision #1965. Remove Evidence-based and All sources chips from answer footer #293 is correctly queued for closure; chore(deps-dev): bump prettier from 3.9.1 to 3.9.4 #312 is correctly kept open for Firefox/WebKit revision reporting and the Chromium-only-cache regression. No additional P0–P2 defect was confirmed. The PR title still says both issues close, but the canonical request payload for chore(deps-dev): bump prettier from 3.9.1 to 3.9.4 #312 is correct.
  • Adversarial review: CodeRabbit was rate-limited, so a distinct manual adversarial pass checked target existence/state, duplicate pending requests, cited merge commits, and the related Fix content access gaps for anonymous and public document users #265 dependency. No actionable finding remained.
  • Threads: 1/1 resolved and outdated; 0 actionable threads remain.
  • Local verification: npm run format; npm run check:outstanding-issues; npm run check:branch-review-ledger; npm run check:ledger-write-discipline; git diff --check — all passed. No product/browser suite was run because the PR delta is limited to immutable review records and issue-inbox requests.
  • Exact-head CI: required PR required, Static PR checks, Change scope, PR policy, PR mergeability, Semgrep, Gitleaks, GitGuardian — all green. Product/build/UI/Lighthouse/migration jobs were correctly skipped by scope; advisory UI, visual baselines, Supabase Preview, and release browser matrix were skipped, not green.
  • Blockers: none. Residual risk is limited to later inbox reconciliation; this PR intentionally does not mutate the canonical issue ledger. Auto-merge is not armed and was not changed.

The PR was not merged. Final merge is left to the user.

@BigSimmo
BigSimmo enabled auto-merge (squash) August 15, 2026 12:54
@BigSimmo
BigSimmo merged commit 8f5ffeb into main Aug 15, 2026
24 checks passed
@BigSimmo
BigSimmo deleted the claude/ledger-review-triage-yi63ao branch August 15, 2026 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants