Archive retired backfill one-shots (ledger #194) - #1947
Conversation
Ledger #194: three of the five backfill scripts named in the row are completed one-time migrations with no live invocation (no npm script in backfill-document-covers.mjs's case, and only manual npm run entries for the other two; none referenced in .github/workflows/ or any scheduled job) — move them to scripts/archive/ following the existing check-m13-migration.ts / check-july8-live-batch.ts pattern: - backfill-document-covers.mjs: covers are now generated inline by the ingestion pipeline (worker/main.ts, worker/python/extract_pdf_assets.py); this was the one-time catch-up for documents indexed before that. No npm script existed; still runnable directly. tests/document-cover-thumbnails.test.ts reads its source for a pagination-safety assertion — import path updated. - backfill-document-tags.ts / backfill-enrichment.ts: already flagged as one-shot archive candidates in docs/scripts-index.md. npm scripts (tags:backfill / enrich:backfill) repointed at the archive path so they stay runnable, matching the check:m13-migration precedent. The other two named scripts (backfill-gold-document-labels.ts, backfill-smart-index.ts) are left in place: docs/scripts-index.md and docs/codebase-index.md already classify both as [live] ongoing governance/indexing tooling, not completed migrations, and archiving them would contradict that established convention. Also confirmed the ledger row's second claim: no dead "ci-change-scope" token exists. scripts/ci-change-scope.mjs is live, central CI-scope classification tooling, referenced by .github/workflows/ci.yml, verify-pr-local.mjs, verify-phone-chrome.mjs, productivity-core.mjs, check-format-changed.mjs, and tests/ci-cache-safety.test.ts. No action taken on that half of the row. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QLbw9qpfjv5CeNz6XpmteN
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 35 minutes Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (6)
Comment |
…merged #215, #210, and #293 were queued as `done` in this same PR, each citing a PR (#1949, #1953, #1962) that turned out still to be open, not merged — verified by checking whether each PR's actual file change is present on origin/main (none are). Reconciling the original `done` requests would have closed these rows while their fixes exist only on unmerged branches, one of which (#1949) currently has failing required CI. Converts all three to `update` requests documenting the correction and the real current state, so reconciling this PR now cannot close a row before its fix has actually landed. Leaves #98, #189, and #194 as `done` unchanged — those cite PR #1950 and PR #1947, both confirmed merged into main.
Summary
backfill-document-covers.mjs,backfill-document-tags.ts, andbackfill-enrichment.tstoscripts/archive/, following the existingcheck-m13-migration.ts/check-july8-live-batch.tsarchive pattern (npm scripts repointed at the new path so they stay runnable; no npm script existed for the covers script, so it's invoked directly at its new path).tests/document-cover-thumbnails.test.ts's source-read path for the moved covers script (it asserts a pagination-safety property of that script's source, so the test stays live rather than being archived alongside it).docs/scripts-index.mdto record the archive moves and explain why the other two scripts the ledger row named (backfill-gold-document-labels.ts,backfill-smart-index.ts) were not archived.ci-change-scopetoken — does not apply: that script is live, central CI tooling.Docs/scripts only. No application code, CI workflow files, or clinical/RAG surfaces touched.
Verification
npm run docs:check-scripts—docs script-ref check passed: 473 npm-run reference(s) resolve to real scripts.npm run verify:pr-local(heavy scope, triggered by thepackage.json+ test-file changes) — all steps passed except one pre-existing, unrelated failure (see Notes):check:runtime—PASS: Node runtime 24.19.0 matches required Node 24.x./PASS: npm runtime 11.17.0 matches required npm 11.x.check:installed-lock-parity—full tree: 760 package locations; 51566 files.format:changed—All matched files use Prettier code style!docs:check-inventory—Docs inventory current: 237 script files, 245 npm scripts.docs:check-links—docs link check passed: 1736 repo path references resolve.lint/typecheck— cleantest—Test Files 601 passed (601)/Tests 6509 passed | 4 skipped (6513)build—Compiled successfully in 57s,Client bundle secret surface check passed.check:rag:fixtures—Offline RAG fixture and manifest validation passed (36 golden cases, 23 suites).check:medication-interactions—data/medication-interaction-index.json is up to date (523 rows).check:medication-lexicon-report— FAILED, pre-existing and unrelated to this diff (see Notes)npm run verify:ui— not applicable, no UI/routing/styling changenpm run verify:release— not applicable, not a release/handoff gateRisk and rollout
.github/workflows/,worker/, or any Railway config (checked directly — no scheduled/cron jobs reference any of the five). All three archived scripts remain runnable at their new path.git revertthis commit; it only moves files and edits docs/package.jsonscript paths.Notes
Ledger #194, part 1 (five backfill one-shots) — three archived, two kept:
Archived (confirmed no live invocation — no
.github/workflows/reference, noworker/reference, no Railway cron/scheduled-job reference, and only a manual npm-run entry point or none at all):backfill-document-covers.mjs— the ingestion pipeline (worker/main.ts,worker/python/extract_pdf_assets.py) now generatescover_pageimages inline for every newly-indexed PDF; this script was the one-time catch-up for documents indexed before that landed. It had no npm script (only directnode scripts/...invocation) and is not referenced anywhere excepttests/document-cover-thumbnails.test.ts, which reads its source text to assert a real pagination-safety property (a stableORDER BYfor PostgREST range scans) — that test's import path was updated to the new archive location so the assertion keeps running.backfill-document-tags.ts/backfill-enrichment.ts— both were already listed as one-shot archive candidates indocs/scripts-index.md's "Remaining candidates" line before this PR. Their npm scripts (tags:backfill,enrich:backfill) are repointed at the archive path rather than removed, matching howcheck:m13-migration/check:july8-live-batchstay runnable after archiving.Not archived, despite being named in the ledger row:
backfill-gold-document-labels.tsandbackfill-smart-index.ts. Both are already classified as[live]ongoing tooling indocs/scripts-index.md(Document intelligence & governance / Ingestion, indexing & reindex sections) and indocs/codebase-index.md— not in the doc's "One-shot / dated — archive candidates" section. Archiving them would contradict this repo's own established, pre-existing convention for distinguishing completed migrations from ongoing tooling, so they were left in place. Flagged indocs/scripts-index.mdfor visibility.Ledger #194, part 2 (dead
ci-change-scopetoken) — confirmed not applicable, no action taken:ci-change-scopeis live, central CI-scope classification tooling wired into.github/workflows/ci.ymland four other scripts plus a test. No dead token exists to remove — that half of ledger row #194 was already stale before this pass, as the prior pass suspected.Pre-existing, unrelated gate failure observed during verification:
check:medication-lexicon-reportfails ("docs/medication-interaction-lexicon-review.mdis stale") on this branch. Confirmed viagit diff origin/main -- docs/medication-interaction-lexicon-review.md scripts/build-medication-lexicon-report.tsreturning empty — neither file differs fromorigin/mainon this branch, so the failure is pre-existing repo drift unrelated to this PR's scope and was not fixed here to avoid expanding this single-task docs/scripts PR into an unrelated surface.Co-Authored-By: Claude Sonnet 5 noreply@anthropic.com
Generated by Claude Code