docs(issues): correct #210 — the prescribed fix would be reverted by Next - #1929
Conversation
…erted by Next The 2026-08-12 re-scope on #210 was half wrong in a way that would have cost the next agent a change Next silently undoes: - `npm run typecheck` already runs `tsc -p tsconfig.typecheck.json` (package.json:38-39), which excludes `.next/**` outright — the row's claim that `npm run ensure` breaks repo-wide typecheck is false, and tsconfig.typecheck.json's own header cites that row as its reason. - Dropping `.next/dev/types/**/*.ts` from tsconfig.json's `include` does not hold: Next emits the glob deliberately (type-paths.js:34-36) and writeConfigurationDefaults.js:305-315 pushes any missing type glob back into an existing `include` on every dev/build run. What remains is narrower and explicitly unproven: run-playwright.mjs writes an isolated tsconfig that inherits the root include globs, and Next's dev-types filter is not reached because `useTypeScriptCli` defaults true. The row now says reproduce before changing anything. PR #1880 reached both corrections independently but its diff never touched the ledger, so they lived only in that PR body until now. Queued as an immutable inbox request rather than a direct canonical-ledger edit; apply with `npm run issues:reconcile` from a fresh ledger branch. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017paT42ZVMf8jaLtkjFxdy5
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 52 minutes Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
Comment |
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017paT42ZVMf8jaLtkjFxdy5
Codex final review summaryFinal head: Merge and syncNo base sync was performed. The branch is behind but clean, and there is no merge or required-CI blocker that justifies restarting green CI. The exact-head The cached Review resultNo confirmed P0, P1 or reproducible P2 defect was found. No file edit, commit or push was warranted. Validated independently:
The underlying Playwright reproduction remains pre-existing/deferred work under Independent adversarial passCodeRabbit selected both files but did not complete a review because its review limit/spending cap was reached. A separate manual adversarial pass against repository contracts and upstream Next.js 16.3.0 source found no correctness, compatibility, concurrency, security, privacy or scope defect. Threads and checks
Exact-head hosted checks:
Limitations and residual riskA fresh full local The PR was not merged. Final merge is left to the user. |
CI triageCI failed on this PR. Automated classification of the 2 failed job(s):
Compared with main CI run #10722 (success). Classification is evidence routing, not permission to ignore a failure. Exact quarantined Playwright identities remain governed by the flake ledger. |
Summary
docs—#210corrected. The 2026-08-12 re-scope on this row was itself half wrong, and the fix it prescribed would have been silently reverted by Next — so the row as written would have sent the next agent into a no-op diff that reads as churn. Two corrections, both re-verified against a freshly installed, parity-clean tree:npm run typecheckrunstsc -p tsconfig.typecheck.json(package.json:38-39), and that config excludes.next/**outright.tsconfig.typecheck.json's own header comment cites#210by number as the reason it exists. The row's claim thatnpm run ensurebreaks repo-widenpm run typecheckis false..next/dev/types/**/*.tsfromtsconfig.json'sincludecomes straight back: Next 16 emits that glob deliberately (node_modules/next/dist/lib/typescript/type-paths.js:34-36, "to avoid tsconfig churn when switching between dev/build modes") andwriteConfigurationDefaults.js:305-315pushes any missing type glob back into an existingincludeon everynext dev/next build.scripts/run-playwright.mjs:253-268writes an isolated tsconfig that sets onlyextends: "../../tsconfig.json"pluscompilerOptions, so it inherits the root include globs including the dev-types one; Next's own dev-types filter (getDevTypesPath, called only fromrunTypeCheck.js:37) is not reached becauseexperimental.useTypeScriptClidefaults true (config-shared.js:257) andnext buildtherefore shells to the TypeScript CLI. Nobody has reproduced the Playwright build failure sincetsconfig.typecheck.jsonlanded, so the row now records this as not proven end-to-end and says reproduce before changing anything..claude/hooks/session-start.shanddocs/database-drift-detection.md— it never edited the ledger. The correction existed solely in that PR body, where nothing reads it, while the canonical row kept directing the opposite change. This PR moves it into the ledger.docs/outstanding-issues.mddirectly and was correctly refused by the pre-push ledger-write guard; that commit was dropped and re-queued throughnpm run issues:update, which writes an immutable merge-safe request underdocs/outstanding-issues-inbox/. Apply withnpm run issues:reconcilefrom a fresh ledger branch after this lands.Verification
npm run verify:pr-localcheck:installed-lock-parityfailed on the first gate run after this branch was cut from amainthat had moved 591 commits (installed file inventory differs from the trusted post-install stamp). Fixed withnpm ci --include=dev, never by re-stamping — and every claim quoted above was then re-read from the reinstalled tree, since the original reads came from a tree that had just failed parity.next 16.3.0; all three cited line numbers hold unchanged.UI verification not run: no UI, routing, styling, or browser-behaviour change in this diff.
Risk and rollout
docs/outstanding-issues-inbox/. No application source, no dependency, no schema, no workflow, and the canonical ledger is untouched until a separate reconcile step applies it.git revertthe single commit, or delete the request file before reconciliation.nextpackage; nothing reads or mutates Supabase, OpenAI, Railway or hosted CI.Notes
## Clinical Governance Preflightsection:classifyPullRequestFilesreturnsclinicalRisk: false,operationalRisk: false,ragRanking: false,ui: falsefor a singledocs/outstanding-issues-inbox/**path, and the diff touches no ingestion, answer-generation, ranking, source-rendering, document-access or privacy surface.Generated by Claude Code